Skip to content

Add reusable OSSF Scorecard workflow - #224

Merged
trask merged 6 commits into
open-telemetry:mainfrom
trask:scorecard-shared-workflow
Aug 6, 2026
Merged

Add reusable OSSF Scorecard workflow#224
trask merged 6 commits into
open-telemetry:mainfrom
trask:scorecard-shared-workflow

Conversation

@trask

@trask trask commented Aug 5, 2026

Copy link
Copy Markdown
Member

Makes the repo-internal Scorecard workflow a reusable workflow that other repositories can call, and narrows what it uploads to code scanning to DangerousWorkflowID, PinnedDependenciesID, and TokenPermissionsID. The full Scorecard result is still published, so the badge and the public api.scorecard.dev entry are unaffected.

The filter runs in a second job because scorecard-action verifies the job that publishes results and rejects any step that is not a uses: of an allow-listed action, so a run: step cannot sit alongside it. Rule definitions are left in the SARIF so the results that are dropped close rather than go stale.

Also gives both this workflow and zizmor.yml a static concurrency group prefix. ${{ github.workflow }} resolves to the caller's name inside a reusable workflow, so a caller using the common ${{ github.workflow }}-${{ github.ref }} group collides with it. Measured in a fork: the collision fails the run outright, with zero jobs and zero steps executed and no message surfaced through the checks API. zizmor.yml is called by around 23 repositories today, none of which currently declare a concurrency group.

Part of open-telemetry/sig-security#309.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a reusable OSSF Scorecard workflow supporting sig-security#309.

Changes:

  • Enables workflow_call and documents adoption.
  • Filters SARIF uploads to three actionable checks.
  • Adds catalog and ownership metadata.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.github/workflows/scorecard.yml Adds reuse and SARIF filtering.
scorecard/README.md Documents usage and filtering.
README.md Adds the workflow catalog entry.
CONTRIBUTING.md Reclassifies Scorecard as shared.
.github/workflows/README.md Updates workflow categories.
.github/CODEOWNERS Assigns Scorecard ownership.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/scorecard.yml Outdated
@trask
trask requested a balanced review from Copilot August 5, 2026 17:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Comment thread .github/workflows/scorecard.yml
@trask
trask requested a balanced review from Copilot August 5, 2026 17:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

@trask
trask marked this pull request as ready for review August 5, 2026 18:12
@trask
trask requested review from a team and maryliag as code owners August 5, 2026 18:12
@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Aug 5, 2026

Copy link
Copy Markdown

Pull request dashboard status

Merged · refreshed 2026-08-06 13:40 UTC

Status above doesn't look right?
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

@trask

This comment was marked as low quality.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@trask
trask requested a balanced review from Copilot August 5, 2026 23:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

@trask
trask merged commit f13d0cb into open-telemetry:main Aug 6, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants