Skip to content

internal/compiler: fix variadic arity in native method calls#990

Merged
gazerro merged 5 commits intomainfrom
fix-975
Feb 23, 2026
Merged

internal/compiler: fix variadic arity in native method calls#990
gazerro merged 5 commits intomainfrom
fix-975

Conversation

@gazerro
Copy link
Member

@gazerro gazerro commented Feb 21, 2026 •
edited
Loading 

internal/compiler: fix variadic arity in native method calls

Previously, concrete method-call emission mutated call arguments and
could overcount variadic arguments. This change preserves user call
arguments for arity computation and keeps synthetic receiver handling
local to parameter emission.

It also updates regression coverage for variadic native method calls, 
including special-call expansion m(g()).

Fixes #900

@gazerro
internal/compiler: fix variadic arity in native method calls
896f0c0 
Previously, concrete method-call emission mutated call arguments and
could overcount variadic arguments. This change preserves user call
arguments for arity computation and keeps synthetic receiver handling
local to parameter emission.

It also updates regression coverage for variadic native method calls,
including special-call expansion m(g()).

Fixes #975
@gazerro gazerro requested a review from zapateo February 21, 2026 13:37
This was linked to issues Feb 21, 2026
Invalid behavior when calling variadic methods #900
Closed
Panic when calling local.E.GET(...) directly, but calling function value fn := local.E.GET works normally #975
Open
zapateo
zapateo requested changes Feb 23, 2026
View reviewed changes
@gazerro gazerro requested a review from zapateo February 23, 2026 14:00
@gazerro gazerro removed a link to an issue Feb 23, 2026
Panic when calling local.E.GET(...) directly, but calling function value fn := local.E.GET works normally #975
Open
zapateo
zapateo requested changes Feb 23, 2026
View reviewed changes
@gazerro gazerro requested a review from zapateo February 23, 2026 16:26
@gazerro gazerro merged commit c3f16bc into main Feb 23, 2026
@gazerro gazerro deleted the fix-975 branch February 23, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zapateo zapateo zapateo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Invalid behavior when calling variadic methods

2 participants

@gazerro @zapateo