internal/compiler: propagate template format across extends#994
Open
gazerro wants to merge 1 commit intomacro-return-markdown-conversionfrom
Open
internal/compiler: propagate template format across extends#994gazerro wants to merge 1 commit intomacro-return-markdown-conversionfrom
gazerro wants to merge 1 commit intomacro-return-markdown-conversionfrom
Conversation
Previously template compilation preserved the entry file format even
after rewriting the tree through extends; for example, with 'index.md'
containing '{% extends "layout.html" %}'', the compiled main function
still had Markdown format instead of HTML.
This commit propagates 'tree.Format' while resolving extends chains, so
the compiled main template function reflects the format of the final
extended template.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.