cmd/scriggo: improve Markdown handling in scriggo serve#996
Open
cmd/scriggo: improve Markdown handling in scriggo serve#996
Conversation
Previously Markdown-to-HTML conversion after macro calls wrongly used the caller format instead of the macro format. This caused Markdown macro output to be lost in HTML contexts. This commit aligna macro return conversion with call-time semantics so conversion is driven by the called macro format, and add regression tests for direct and indirect Markdown macro calls from HTML templates.
Previously template compilation preserved the entry file format even
after rewriting the tree through extends; for example, with 'index.md'
containing '{% extends "layout.html" %}'', the compiled main function
still had Markdown format instead of HTML.
This commit propagates 'tree.Format' while resolving extends chains, so
the compiled main template function reflects the format of the final
extended template.
Implement 'Template.Format', which reports the output format produced when executing a template.
Improve the scriggo serve command handling of Markdown files: - Serve .md files as-is when explicitly requested (no HTML rendering). - When a path has no extension, and no corresponding .html file exists but a matching .md file does, render the Markdown and wrap it in a full HTML page before serving. Closes #974
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE