Skip to content

fix pv 3p1p failed phase switch #2173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LKuemmel merged 1 commit into from
Jan 24, 2025
Merged

fix pv 3p1p failed phase switch #2173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions packages/control/chargepoint/chargepoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,9 +383,7 @@ def _is_phase_switch_required(self) -> bool:
# Umschaltung fehlgeschlagen
if self.data.set.phases_to_use != self.data.get.phases_in_use:
if data.data.general_data.data.chargemode_config.retry_failed_phase_switches:
if self.data.control_parameter.failed_phase_switches <= self.MAX_FAILED_PHASE_SWITCHES:
self.data.control_parameter.failed_phase_switches += 1
else:
if self.data.control_parameter.failed_phase_switches > self.MAX_FAILED_PHASE_SWITCHES:
phase_switch_required = False
self.set_state_and_log(
"Keine Phasenumschaltung, da die maximale Anzahl an Fehlversuchen erreicht wurde. Die "
Expand All @@ -396,6 +394,7 @@ def _is_phase_switch_required(self) -> bool:
"Keine Phasenumschaltung, da wiederholtes Anstoßen der Umschaltung in den übergreifenden "
"Ladeeinstellungen deaktiviert wurde. Die aktuelle "
"Phasenzahl wird bis zum Abstecken beibehalten.")
self.data.control_parameter.failed_phase_switches += 1
return phase_switch_required

STOP_CHARGING = ", dafür wird die Ladung unterbrochen."
Expand Down Expand Up @@ -828,11 +827,19 @@ def cp_ev_chargemode_support_phase_switch(self) -> bool:
control_parameter.submode == Chargemode.PV_CHARGING and
data.data.general_data.get_phases_chargemode(Chargemode.SCHEDULED_CHARGING.value,
control_parameter.submode) == 0)
if ((data.data.general_data.data.chargemode_config.retry_failed_phase_switches and
self.data.control_parameter.failed_phase_switches > self.MAX_FAILED_PHASE_SWITCHES) or
(data.data.general_data.data.chargemode_config.retry_failed_phase_switches is False and
self.data.control_parameter.failed_phase_switches == 1)):
failed_phase_switches_reached = True
else:
failed_phase_switches_reached = False
return (self.cp_ev_support_phase_switch() and
self.data.get.charge_state and
(pv_auto_switch or scheduled_auto_switch) and
control_parameter.state == ChargepointState.CHARGING_ALLOWED or
control_parameter.state == ChargepointState.PHASE_SWITCH_DELAY)
(control_parameter.state == ChargepointState.CHARGING_ALLOWED or
control_parameter.state == ChargepointState.PHASE_SWITCH_DELAY) and
failed_phase_switches_reached is False)

def cp_ev_support_phase_switch(self) -> bool:
return (self.data.config.auto_phase_switch_hw and
Expand Down