SoC Skoda and VWId using VW Group #2325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 14, 2025
Closed
LKuemmel
requested changes
May 7, 2025
Contributor
LKuemmel
left a comment
LKuemmel
left a comment
There was a problem hiding this comment.
Die Klassenaufteilung passt.
Ist das deaktivierte SokaConnect-Modul obsolet?
| a = api(conf, vehicle) | ||
| soc, range, soc_ts, soc_tsX = loop.run_until_complete(a._fetch_soc()) | ||
|
|
||
| return soc, range, soc_ts, soc_tsX |
Contributor
There was a problem hiding this comment.
Für was steht denn das X in soc_tsX? Ist soc_ts_server ausssagekräftiger?
Collaborator
There was a problem hiding this comment.
''' Für was steht denn das X in soc_tsX? Ist soc_ts_server ausssagekräftiger?
Das stammt ursprünglich aus dem vwid Modul:
soc_ts und soc_tsX beschreiben denselben Zeitpunkt, soc_ts als string, soc_tsX als timestamp.
der String wird im Log benutzt, der timestamp für den car_state.
Contributor
Author
Ja, ich wollte das nur nicht hier reinmischen, aber später einen eigenen PR zum Aufräumen erstellen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing shared component VWGroup that provides general SoC handling for vehicles from VW group.
Also included:
The changes were tested by me with Skoda Enyaq and by @rleidner for VW.
Related UI extension is included in PR #699