polestar auth change: update resume path #2352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LKuemmel
requested changes
May 7, 2025
|
|
||
| # auth step 3: get token | ||
| def get_auth_token(self) -> Optional[str]: | ||
| def get_auth_token(self) -> str or None: |
Contributor
There was a problem hiding this comment.
Suggested change
| def get_auth_token(self) -> str or None: | |
| def get_auth_token(self) -> Optional[str]: |
Die Schreibweise folgt dem Python Style Guide.
|
|
||
| # auth step 2: get code | ||
| def _get_auth_code(self) -> Optional[str]: | ||
| def _get_auth_code(self) -> str or None: |
Contributor
There was a problem hiding this comment.
Suggested change
| def _get_auth_code(self) -> str or None: | |
| def _get_auth_code(self) -> Optional[str]: |
|
|
||
| # auth step 1: get resumePath | ||
| def _get_auth_resumePath(self) -> Optional[str]: | ||
| def _get_auth_resumePath(self) -> str or None: |
Contributor
There was a problem hiding this comment.
Suggested change
| def _get_auth_resumePath(self) -> str or None: | |
| def _get_auth_resumePath(self) -> Optional[str]: |
| try: | ||
| result = self.client_session.post( | ||
| BASE_URL+f"/as/{self.resume_path}/resume/as/authorization.ping", | ||
| BASE_URL + f"{self.resume_path}", |
Contributor
There was a problem hiding this comment.
Suggested change
| BASE_URL + f"{self.resume_path}", | |
| f"{BASE_URL}{self.resume_path}", |
Hier vermischt Du zwei Darstellungsweisen eines Strings.
Oder die ältere Variante:
Suggested change
| BASE_URL + f"{self.resume_path}", | |
| BASE_URL + self.resume_path, |
| data = {"pf.submit": True, "subject": uid} | ||
| result = self.client_session.post( | ||
| BASE_URL+f"/as/{self.resume_path}/resume/as/authorization.ping", | ||
| BASE_URL + f"{self.resume_path}", |
Contributor
There was a problem hiding this comment.
Suggested change
| BASE_URL + f"{self.resume_path}", | |
| f"{BASE_URL}{self.resume_path}", |
Contributor
Author
|
Das war wohl ein Schnellschuss... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wieder mal eine Änderung der Authentifizierung: der resume_path muss anders geholt werden