Conversation
benderl
requested changes
May 13, 2025
|
|
||
| class JsonBatConfiguration: | ||
| def __init__(self, | ||
| jq_currents: Optional[str] = None, |
Contributor
There was a problem hiding this comment.
Es können je nach JSON Objekt nicht immer alle Ströme mit einem Pattern ermittelt werden. Die Implementation hier sollte sich an der Konfiguration der Counter Komponente orientieren und einzelne Pattern für jede Phase anbieten.
| @auto_str | ||
| class HttpBatConfiguration: | ||
| def __init__(self, power_path=None, soc_path=None, imported_path=None, exported_path=None): | ||
| def __init__(self, power_path=None, soc_path=None, currents_path=None, imported_path=None, exported_path=None): |
Contributor
There was a problem hiding this comment.
Auch hier sollten analog zur Counter Komponente einzelne URLs je Phase angeboten werden.
benderl
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openWB/tools#20
openWB/openwb-ui-settings#717