Skip to content

adjust modbus id#2439

Merged
LKuemmel merged 2 commits intoopenWB:masterfrom
ndrsnhs:fix-alpha-counter
Jun 10, 2025
Merged

adjust modbus id#2439
LKuemmel merged 2 commits intoopenWB:masterfrom
ndrsnhs:fix-alpha-counter

Conversation

@ndrsnhs
Copy link
Contributor

@ndrsnhs ndrsnhs commented Jun 10, 2025

No description provided.

@fawick
Copy link
Contributor

fawick commented Jun 10, 2025

@ndrsnhs Were you able to verify whether the changes in this PR are compatible with pre-2022 devices (e.g AlphaESS Smile B3)? AlphaESS tended to experiment with ModBus TCP register definitions quite a bit over the last years, leading to inconsistencies.

@ndrsnhs
Copy link
Contributor Author

ndrsnhs commented Jun 10, 2025

Due to a change in providing the Modbus ID the module is no longer able to read values from the grid meter at all. This PR doesn't affect the adresses of any registers. It basically removes subfunctions to reduce complex code design and improve readability. The check for API versions moved from line 39 to line 35, directly followed by reading the specified registers.
Due to the lack of pre v123 systems it's currently tested on post v123 systems only.
Conclusion: If the AlphaESS System delivered values before the change it will do so in the future. If this is about a new/ unsupported system I need further Information...

@fawick
Copy link
Contributor

fawick commented Jun 10, 2025

Understood, thank you for clarifying this.

@LKuemmel LKuemmel merged commit 59db735 into openWB:master Jun 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants