Skip to content

fix set bat power limit #2451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LKuemmel merged 1 commit into from
Jun 13, 2025
Merged

fix set bat power limit #2451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/helpermodules/setdata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,13 +634,13 @@ def process_bat_topic(self, msg: mqtt.MQTTMessage):
self._validate_value(msg, float)
elif "openWB/set/bat/get/soc" in msg.topic:
self._validate_value(msg, float, [(0, 100)])
elif "openWB/set/bat/get/power" in msg.topic:
elif ("openWB/set/bat/get/power" in msg.topic or
"openWB/set/bat/set/power_limit" in msg.topic):
self._validate_value(msg, float)
elif ("openWB/set/bat/get/imported" in msg.topic or
"openWB/set/bat/get/exported" in msg.topic or
"openWB/set/bat/get/daily_exported" in msg.topic or
"openWB/set/bat/get/daily_imported" in msg.topic or
"openWB/set/bat/set/power_limit" in msg.topic):
"openWB/set/bat/get/daily_imported" in msg.topic):
self._validate_value(msg, float, [(0, float("inf"))])
elif "openWB/set/bat/get/fault_state" in msg.topic:
self._validate_value(msg, int, [(0, 2)])
Expand Down
2 changes: 1 addition & 1 deletion packages/modules/devices/victron/victron/bat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ def set_power_limit(self, power_limit: Optional[int]) -> None:
self.__tcp_client.write_registers(2902, [3], data_type=ModbusDataType.UINT_16, unit=modbus_id)
self.__tcp_client.write_registers(39, [1], data_type=ModbusDataType.UINT_16, unit=228)
self.last_mode = 'stop'
elif power_limit > 0:
elif power_limit < 0:
if self.last_mode != 'discharge':
# ESS Mode 3 für externe Steuerung und auf L1 wird entladen
self.__tcp_client.write_registers(2902, [3], data_type=ModbusDataType.UINT_16, unit=modbus_id)
Expand Down