Skip to content

Make history chart legend scrollable (standard legacy) #2465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benderl merged 1 commit into from
Jun 17, 2025
Merged

Make history chart legend scrollable (standard legacy) #2465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/modules/web_themes/standard_legacy/web/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,12 @@
<span class="collPlus"></span>
</div>
<div id="cardGraph" class="card-body collapse show">
<div class="row justify-content-center my-2" id="theGraph">
<div class="row justify-content-center" >
<div class="col-sm-12 mt-2">
<div id="custom-legend-container"></div>
</div>
</div>
<div class="row justify-content-center mb-2" id="theGraph">
<!-- will be refreshed using MQTT (in livechart.js)-->
<div class="col-sm-12 text-center smallTextSize">
<div id="waitForGraphLoadingDiv">
Expand All @@ -357,6 +362,7 @@
</div>
</div>
</div>

</div>
</div>
</div>
Expand Down
45 changes: 42 additions & 3 deletions packages/modules/web_themes/standard_legacy/web/livechart.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,41 @@ var chartDatasets = [
}
];

// Generate custom legendAdd commentMore actions
function generateCustomLegend(chart) {
const legendContainer = document.getElementById('custom-legend-container');
// Clear existing legend
legendContainer.innerHTML = '';
// Create legend items
chart.data.datasets.forEach((dataset, index) => {
if (!dataset.label) return;
const legendItem = document.createElement('div');
legendItem.className = 'legend-item';
if (chart.getDatasetMeta(index).hidden) {
legendItem.className += ' hidden';
}
const colorBox = document.createElement('span');
colorBox.className = 'legend-color-box';
colorBox.style.backgroundColor = dataset.borderColor;
const text = document.createElement('span');
text.textContent = dataset.label;
legendItem.appendChild(colorBox);
legendItem.appendChild(text);
// toggle visibility
legendItem.onclick = ()=> {
const item = chart.getDatasetMeta(index);
item.hidden = !item.hidden;
if (item.hidden) {
legendItem.classList.add('hidden');
} else {
legendItem.classList.remove('hidden');
}
chart.update();
};
legendContainer.appendChild(legendItem);
});
}

function loadGraph(animationDuration = 1000) {

var chartData = {
Expand Down Expand Up @@ -295,8 +330,12 @@ function loadGraph(animationDuration = 1000) {
window.myLine = new Chart(ctx, {
type: 'line',
plugins: [{
afterInit: doGraphResponsive,
resize: doGraphResponsive
afterInit: (chart) => {
doGraphResponsive(chart);
generateCustomLegend(chart);
},
resize: doGraphResponsive,
afterUpdate: generateCustomLegend
}],
data: chartData,
options: {
Expand All @@ -308,7 +347,7 @@ function loadGraph(animationDuration = 1000) {
enabled: true
},
legend: {
display: true,
display: false,
labels: {
color: fontColor,
// filter: function(item,chart) {
Expand Down
75 changes: 75 additions & 0 deletions packages/modules/web_themes/standard_legacy/web/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,3 +476,78 @@ h3 {
transition: none;
display: none;
}

/* Custom legend container */
#custom-legend-container {
max-height: 120px;
margin-bottom: 10px;
overflow-y: auto;
border: 1px solid #ccc;
border-radius: 5px;
padding-top: 2px;
padding-bottom: 2px;
text-align: left;
display: flex;
flex-wrap: wrap;
justify-content: center;
}

/* Legend item styling */
.legend-item {
display: inline-flex;
align-items: center;
cursor: pointer;
user-select: none;
padding: 2px 5px;
border-radius: 3px;
font-size: 14px;
color: rgba(0,0,0,0.65);
}

.legend-item:hover {
background-color: rgba(0,0,0,0.05);
}

.legend-color-box {
display: inline-block;
width: 16px;
height: 4px;
margin-right: 4px;
}

.legend-item.hidden {
opacity: 0.6;
text-decoration: line-through;
}

/* Make the container responsive */
@media (max-width: 768px) {
#custom-legend-container {
max-height: 100px;
}

.legend-item {
font-size: 0.8em;
margin-right: 5px;
margin-bottom: 3px;
}

.legend-color-box {
width: 12px;
height: 3px;
margin-right: 4px;
}
}

/* For smaller screens */
@media (max-width: 576px) {
#custom-legend-container {
max-height: 80px;
}

.legend-color-box {
width: 10px;
height: 2px;
margin-right: 4px;
}
}