Update time and scheduled charging plans for new topic structure (Koala theme) #2480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LKuemmel
force-pushed
the
feature-integrated-charging-plans
branch
from
1d913e5 to
8da6e31
Compare
LKuemmel
reviewed
Jun 25, 2025
Comment on lines
2445
to
2599
| const plans = vehicleScheduledChargingPlans.value(chargePointId); | ||
| const plan = plans.find((p) => p.id === planId); | ||
| return plan?.phases_to_use_pv; | ||
| }, | ||
| set(newValue: number) { | ||
| const baseTopic = `openWB/chargepoint/${chargePointId}/set/charge_template/chargemode/scheduled_charging/plans/${planId}`; | ||
| updateTopic(baseTopic, newValue, 'phases_to_use_pv', true); | ||
| const plans = vehicleScheduledChargingPlans.value(chargePointId); | ||
| const planIndex = plans.findIndex((plan) => plan.id === planId); | ||
| if (planIndex === -1) return; | ||
| const objectPath = `chargemode.scheduled_charging.plans.${planIndex}.phases_to_use_pv`; | ||
| updateTopic( | ||
| `openWB/chargepoint/${chargePointId}/set/charge_template`, | ||
| newValue, | ||
| objectPath, | ||
| true, | ||
| ); |
Contributor
There was a problem hiding this comment.
Hier wird mehrfach der gleiche Code ausgeführt. Kann man das in eine Methode zusammen fassen?
Contributor
Author
There was a problem hiding this comment.
Hilfsfunktion hinzugefügt, um wiederholten Code zu vermeiden.
LKuemmel
force-pushed
the
feature-integrated-charging-plans
branch
from
8da6e31 to
25cbd10
Compare
Contributor
Author
|
SoC-Symbole entfernt, wenn die Energiemenge im Ladeplan aktiv ist. |
Contributor
Kannst Du das bitte in einen eigenen PR packen? Das hat inhaltlich nichts mit der Umstrukturierung der Pläne zu tun und muss auch nicht in den Feature-Branch, sondern kann direkt in den Master. |
Brett-S-OWB
force-pushed
the
integrated-charging-plans
branch
from
17d9168 to
8e39264
Compare
Contributor
Author
|
Commit SoC-Symbole entfernt |
Brett-S-OWB
force-pushed
the
integrated-charging-plans
branch
from
8e39264 to
4755868
Compare
LKuemmel
merged commit 139af9b
into
openWB:feature-integrated-charging-plans
1 check passed
LKuemmel
pushed a commit
that referenced
this pull request
Jun 30, 2025
LKuemmel
pushed a commit
that referenced
this pull request
Jun 30, 2025
LKuemmel
pushed a commit
that referenced
this pull request
Jun 30, 2025
LKuemmel
added a commit
that referenced
this pull request
Jul 1, 2025
* cards display: switch to integrated plans * standard-legacy: switch to integrated plans * backend * fixes * standard legacy: switch to plan lists * cards display: switch to plan lists * plans as list * autolock update config * fixes, remove subdata workaround * fixes * fixes, pytest * fixes * fixes * fix copying auto lock plan * fix initial once timestamp, fix max ids * add missing ids in templates * fix * fix once * fix once * fix pytest * Colors theme: adapt to integrated charging plans (#2495) * adapt to integrated charging plans * align time charging information to new temporary template * fix pricechart axis * Update time and scheduled charging plans for new topic structure (#2480) * fix no plans * build UI * fix update config --------- Co-authored-by: Lutz Bender <github@lutz-bender.de> Co-authored-by: cshagen <cshagen@hagens.ch> Co-authored-by: BrettS <168732306+Brett-S-OWB@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.