Skip to content

Conversation

@ndrsnhs
Copy link
Contributor

@ndrsnhs ndrsnhs commented Jul 7, 2025

No description provided.

@ndrsnhs ndrsnhs requested a review from LKuemmel July 8, 2025 06:43
Comment on lines 62 to 64
log.debug("Tasmota InverterState:\nurl=" + url +
"\nresponse=" + str(response) +
"\nInverterState=" + str(inverter_state))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
log.debug("Tasmota InverterState:\nurl=" + url +
"\nresponse=" + str(response) +
"\nInverterState=" + str(inverter_state))

self.fault_state = FaultState(ComponentInfo.from_component_config(self.component_config))

def update(self):
log.debug("Tasmota inverter update: " + self.__ip_address)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
log.debug("Tasmota inverter update: " + self.__ip_address)

Comment on lines 75 to 77
log.debug("Tasmota CounterState:\nurl=" + url +
"\nresponse=" + str(response) +
"\nCounterState=" + str(counter_state))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
log.debug("Tasmota CounterState:\nurl=" + url +
"\nresponse=" + str(response) +
"\nCounterState=" + str(counter_state))

def update(self):
log.debug("tasmota.counter.update: " + self.__ip_address)
counter_state = self.__tasmota.get_CounterState()
log.debug("Tasmota counter update: " + self.__ip_address)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
log.debug("Tasmota counter update: " + self.__ip_address)

Comment on lines 66 to 68
log.debug("Tasmota BatState:\nurl=" + url +
"\nresponse=" + str(response) +
"\nBatState=" + str(bat_state))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
log.debug("Tasmota BatState:\nurl=" + url +
"\nresponse=" + str(response) +
"\nBatState=" + str(bat_state))

self.fault_state = FaultState(ComponentInfo.from_component_config(self.component_config))

def update(self):
log.debug("Tasmota bat update: " + self.__ip_address)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
log.debug("Tasmota bat update: " + self.__ip_address)

def initialize(self) -> None:
self.__device_id: int = self.kwargs['device_id']
self.__ip_address: str = self.kwargs['ip_address']
self.sim_counter = SimCounter(self.__device_id, self.component_config.id, prefix="speicher")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simcount und device_id wird nicht benötigt oder?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eine der Tasmota Zählervarianten gibt nur einen Gesamtzählerstand aus. Bisher war das als Import Zählerwert implementiert. Der Simcount wird für den Export Zählerstand benötigt.
Ob ['StatusSNS']['ENERGY']['Total'] den Importwert oder eine Kombination aus Im- und Export wiedergibt ist nicht bekannt.
Möglicherweise wäre auch hier der SimCount besser...

@LKuemmel LKuemmel merged commit 3c05987 into openWB:master Jul 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants