Skip to content

loose limits for hardware check #2525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LKuemmel merged 2 commits into from
Jul 8, 2025
Merged

loose limits for hardware check #2525

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be5f81e
loose limits for hardware check
LKuemmel Jul 8, 2025
5ff3976
fix
LKuemmel Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/modules/common/hardware_check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def valid_voltage(voltage) -> bool:
(valid_voltage(voltages[0]) and valid_voltage(voltages[1]) and valid_voltage((voltages[2])))):
return METER_BROKEN_VOLTAGES.format(voltages)
interdependent_values = [sum(counter_state.currents), counter_state.power]
if not (all(v == 0 for v in interdependent_values) or all(v != 0 for v in interdependent_values)):
if not (all(abs(v) < 0.5 for v in interdependent_values) or all(abs(v) > 0.5 for v in interdependent_values)):
return METER_IMPLAUSIBLE_VALUE.format(counter_state.powers, counter_state.currents, counter_state.voltages)
return None

Expand Down