Skip to content

GoodWe second battery; fix no attribute error #2539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LKuemmel merged 4 commits into from
Jul 10, 2025
Merged

GoodWe second battery; fix no attribute error #2539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6f4b12d
add second battery and update config
ndrsnhs Jul 8, 2025
e1d6ff2
fix no attribute error
ndrsnhs Jul 10, 2025
2d779b6
Merge branch 'GoodWe-second-battery' of https://github.com/ndrsnhs/co…
ndrsnhs Jul 10, 2025
974d163
fix register adresses
ndrsnhs Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/modules/devices/good_we/good_we/bat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ def __init__(self, component_config: GoodWeBatSetup, **kwargs: Any) -> None:
self.kwargs: KwargsDict = kwargs

def initialize(self) -> None:
self.__device_id: int = self.kwargs['device_id']
self.__modbus_id: int = self.kwargs['modbus_id']
self.version: GoodWeVersion = self.kwargs['version']
self.firmware: int = self.kwargs['firmware']
Expand All @@ -50,8 +51,8 @@ def update(self) -> None:
exported = self.__tcp_client.read_holding_registers(
35209, ModbusDataType.UINT_32, unit=self.__modbus_id) * 100
else:
power = self.__tcp_client.read_holding_registers(35182, ModbusDataType.INT_32, unit=self.__modbus_id)*-1
soc = self.__tcp_client.read_holding_registers(37007, ModbusDataType.UINT_16, unit=self.__modbus_id)
power = self.__tcp_client.read_holding_registers(35264, ModbusDataType.INT_32, unit=self.__modbus_id)*-1
soc = self.__tcp_client.read_holding_registers(39005, ModbusDataType.UINT_16, unit=self.__modbus_id)
imported, exported = self.sim_counter.sim_count(power)

bat_state = BatState(
Expand Down
1 change: 1 addition & 0 deletions packages/modules/devices/good_we/good_we/device.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ def create_device(device_config: GoodWe):
def create_bat_component(component_config: GoodWeBatSetup):
nonlocal client
return bat.GoodWeBat(component_config=component_config,
device_id=device_config.id,
modbus_id=device_config.configuration.modbus_id,
version=GoodWeVersion(device_config.configuration.version),
firmware=device_config.configuration.firmware,
Expand Down
Loading