Skip to content

SoC Module evcc: fixed API call #2598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benderl merged 5 commits into from
Jul 31, 2025
Merged

SoC Module evcc: fixed API call #2598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
335f291
fixed evcc module API call
lordblobo Jul 26, 2025
63c59ea
proper approach by adding template field to request
lordblobo Jul 27, 2025
0789496
fixed mistake/typo
lordblobo Jul 28, 2025
770661d
fixed indendation
lordblobo Jul 28, 2025
cab462a
also fixed other indents
lordblobo Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/modules/vehicles/evcc/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,13 +69,13 @@ def fetch_soc(
stub = vehicle_pb2_grpc.VehicleStub(channel)

if not evcc_config.vehicle_id: # create and fetch vehicle id if not included in config
create_and_save_vehicle_id(stub, evcc_config, vehicle)
# vehicle_to_fetch = create_vehicle(evcc_config, stub)
# log.debug("Vehicle client received: " + str(vehicle_to_fetch))
vehicle_to_fetch = create_and_save_vehicle_id(stub, evcc_config, vehicle)
# vehicle_to_fetch = create_vehicle(evcc_config, stub)
# log.debug("Vehicle client received: " + str(vehicle_to_fetch))

# saving vehicle id in config
# topic = "openWB/set/vehicle/" + str(vehicle) + "/soc_module/config"
# write_vehicle_id_mqtt(topic, vehicle_to_fetch, evcc_config)
# topic = "openWB/set/vehicle/" + str(vehicle) + "/soc_module/config"
# write_vehicle_id_mqtt(topic, vehicle_to_fetch, evcc_config)
else:
log.debug("Vehicle id found in config: " + str(evcc_config.vehicle_id))
vehicle_to_fetch = evcc_config.vehicle_id
Expand Down
3 changes: 2 additions & 1 deletion packages/modules/vehicles/evcc/vehicle_pb2.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,12 @@ class NewRequest(_message.Message):
def __init__(self, key: _Optional[str] = ..., value: _Optional[str] = ...) -> None: ...
TOKEN_FIELD_NUMBER: _ClassVar[int]
TYPE_FIELD_NUMBER: _ClassVar[int]
TEMPLATE_FIELD_NUMBER: _ClassVar[int]
CONFIG_FIELD_NUMBER: _ClassVar[int]
token: str
type: str
config: _containers.ScalarMap[str, str]
def __init__(self, token: _Optional[str] = ..., type: _Optional[str] = ..., config: _Optional[_Mapping[str, str]] = ...) -> None: ...
def __init__(self, token: _Optional[str] = ..., type: _Optional[str] = ..., template: _Optional[str] = ..., config: _Optional[_Mapping[str, str]] = ...) -> None: ...

class NewReply(_message.Message):
__slots__ = ("vehicle_id",)
Expand Down