Add bidi settings to koala and standard themes#2638
Closed
Brett-S-OWB wants to merge 9 commits intoopenWB:feature_bidifrom
Closed
Add bidi settings to koala and standard themes#2638Brett-S-OWB wants to merge 9 commits intoopenWB:feature_bidifrom
Brett-S-OWB wants to merge 9 commits intoopenWB:feature_bidifrom
Conversation
benderl
requested changes
Aug 8, 2025
Comment on lines
+76
to
+98
| plan: { | ||
| id: number; | ||
| name: string; | ||
| active: boolean; | ||
| current: number; | ||
| dc_current: number; | ||
| et_active: boolean; | ||
| time: string; | ||
| phases_to_use: number; | ||
| phases_to_use_pv: number; | ||
|
|
||
| frequency: { | ||
| selected: string; | ||
| once?: string; | ||
| weekly: boolean[]; | ||
| }; | ||
| limit: { | ||
| selected: string; | ||
| amount?: number; | ||
| soc_limit?: number; | ||
| soc_scheduled?: number; | ||
| }; | ||
| }; |
Contributor
There was a problem hiding this comment.
Hier kannst Du Deine Definition BidiChargingPlan verwenden. Ansonsten ist das Objekt doppelt definiert und der Code sehr anfällig bei Anpassungen.
Contributor
Author
There was a problem hiding this comment.
Wir müssen bidi Charging in die Interface-ChargeTemplateConfiguration aufnehmen, da chargePointConnectedVehicleBidiChargePlan seine Daten aus chargePointConnectedVehicleChargeTemplate bezieht, welches den Typ ChargeTemplateConfiguration hat. Daher habe ich das Interface BidichargingPlan entfernt. Eine Alternative wäre, einen Typ-Alias zu erstellen aber das ist wahrscheinlich nicht unbedingt notwendig.
type BidiChargingPlan = ChargeTemplateConfiguration['chargemode']['bidi_charging']['plan'];
packages/modules/web_themes/koala/source/src/stores/mqtt-store.ts
Outdated
Show resolved
Hide resolved
packages/modules/web_themes/koala/source/src/components/ChargePointBidiSettings.vue
Outdated
Show resolved
Hide resolved
LKuemmel
force-pushed
the
feature_bidi
branch
4 times, most recently
from
3723f3b to
e7e3526
Compare
Contributor
|
Ersetzt durch: #2671 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Koala-Theme –
Füge einen Bidi-Button zu den Ladepunkt-Schaltflächen hinzu.
Füge im Einstellungsdialog die Slider für minimalen Entlade-SoC, Stromstärke und Details des bidirektionalen Ladeplans hinzu.
Standard-Theme –
Füge im Einstellungsdialog die Slider für minimalen Entlade-SoC, Stromstärke und Details des bidirektionalen Ladeplans hinzu.