Skip to content

fix logging of stdout und stderr #2661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LKuemmel merged 3 commits into from
Aug 15, 2025
Merged

fix logging of stdout und stderr #2661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c6946b
fix logging of stdout und stderr
LKuemmel Aug 14, 2025
0d28214
fix
LKuemmel Aug 14, 2025
1368de2
simplify
LKuemmel Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions packages/helpermodules/command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -963,16 +963,17 @@ def __enter__(self):
return None

def __exit__(self, exception_type, exception, exception_traceback) -> bool:
if isinstance(exception, Exception):
if isinstance(exception, subprocess.CalledProcessError):
pub_user_message(self.payload, self.connection_id,
f'Es ist ein interner Fehler aufgetreten: {exception}', MessageType.ERROR)
log.error({traceback.format_exc()})
(f'Fehler-Status: {exception.returncode}<br />Meldung: '
f'{exception.stderr if exception.stderr else ""} '
f'{exception.output if exception.output else ""}'),
MessageType.ERROR)
return True
elif isinstance(exception, subprocess.CalledProcessError):
log.debug(exception.stdout)
elif isinstance(exception, Exception):
pub_user_message(self.payload, self.connection_id,
f'Fehler-Status: {exception.returncode}<br />Meldung: {exception.stderr}',
MessageType.ERROR)
f'Es ist ein interner Fehler aufgetreten: {exception}', MessageType.ERROR)
log.error({traceback.format_exc()})
return True
else:
return False
Expand Down
6 changes: 4 additions & 2 deletions packages/helpermodules/utils/run_command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@ def run_command(command, process_exception: bool = False):
return result.stdout
except subprocess.CalledProcessError as e:
if process_exception:
log.debug(e.stdout)
log.exception(e.stderr)
if e.output is not None:
log.exception(e.output)
if e.stderr is not None:
log.exception(e.stderr)
else:
raise e