Merged
Conversation
tpd-opitz
reviewed
Sep 10, 2025
| # convert miles to km | ||
| range = float(response["response"]["charge_state"]["battery_range"]) * 1.60934 | ||
| soc_timestamp = float(response["response"]["charge_state"]["timestamp"]) | ||
| range = int(float(response["response"]["charge_state"]["battery_range"]) * 1.60934) |
Contributor
There was a problem hiding this comment.
Welche Bedeutung hat 1.60934? -> Konstante mit sprechendem Namen bitte...
Contributor
There was a problem hiding this comment.
Steht in Zeile 48.
ja.... als Kommentar... ;o)
Contributor
Author
There was a problem hiding this comment.
Genau. Und da das die einzige Stelle ist, an der die Zahl verwendet wird, sehe ich keinen Bedarf für eine Konstante, die dann irgendwo losgelöst vom Kontext definiert wird.
LKuemmel
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
minor fixes:
changed: