Merged
Conversation
LKuemmel
approved these changes
Sep 17, 2025
tpd-opitz
reviewed
Sep 17, 2025
LKuemmel
requested changes
Oct 24, 2025
| self.fault_state = FaultState(ComponentInfo.from_component_config(self.component_config)) | ||
|
|
||
| def update(self): | ||
| unit = self.component_config.configuration.modbus_id |
Contributor
There was a problem hiding this comment.
Die Modbus-ID liegt in der Device config. Da über die Wärmepumpe wahrscheinlich keine weiteren Komponenten abgefragt werden können, ist es egal, ob die ModbusID in den Gerät oder Komponenten Einstellungen liegt.
Du kannst im kwargs dict noch die ModbusID ergänzen und dann mit an die Komponente übergeben.
Kannst Du das bitte noch ändern?
Contributor
Author
There was a problem hiding this comment.
Wenn ich es richtig verstanden habe, dann hab ich das so umgesetzt, kannst du nochmal drüberschauen?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openWB/openwb-ui-settings#797