bidi: fix discharging if limit_soc is reached#2775
Merged
LKuemmel merged 2 commits intoopenWB:masterfrom Oct 23, 2025
Merged
Conversation
tpd-opitz
reviewed
Sep 22, 2025
Comment on lines
+553
to
+556
| if (limit.selected == "soc" and | ||
| (soc > limit.soc_limit if (plan.bidi_charging_enabled and bidi_state == BidiState.BIDI_CAPABLE) | ||
| else soc >= limit.soc_limit) and | ||
| soc >= limit.soc_scheduled): |
Contributor
There was a problem hiding this comment.
Suggested change
| if (limit.selected == "soc" and | |
| (soc > limit.soc_limit if (plan.bidi_charging_enabled and bidi_state == BidiState.BIDI_CAPABLE) | |
| else soc >= limit.soc_limit) and | |
| soc >= limit.soc_scheduled): | |
| def is_below(soc: int, soc_limit: int) -> bool: | |
| if plan.bidi_charging_enabled and bidi_state == BidiState.BIDI_CAPABLE: | |
| return soc > soc_limit | |
| else | |
| return soc >= soc_limit | |
| if all(limit.selected == "soc" | |
| soc >= limit.soc_scheduled | |
| is_below(soc, limit.soc_limit)): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wenn der Überschuss-SoC erreicht ist, darf nur noch bidirektional entladen werden, aber nicht weiter geladen.
Überschuss-SoC = 90%
Bidi:
PWM: