Skip to content

Revert "improve syntax"#2790

Merged
benderl merged 1 commit intoopenWB:masterfrom
vuffiraa72:fast-return-false-while-checking
Sep 29, 2025
Merged

Revert "improve syntax"#2790
benderl merged 1 commit intoopenWB:masterfrom
vuffiraa72:fast-return-false-while-checking

Conversation

@vuffiraa72
Copy link
Contributor

@vuffiraa72 vuffiraa72 commented Sep 27, 2025

This reverts commit 51ea8ee.

Mit diesem Commit bekomme ich in meiner Testumgebung folgende Meldung beim Starten einer Systemaktualisierung

2025-09-27 17:13:48,481 - {helpermodules.messaging:60} - {ERROR:Commands} - ERROR:helpermodules.messaging:Messaging: Fehlermeldung: {'source': 'command', 'type': 'danger', 'message': "Es ist ein interner Fehler aufgetreten: 'MqttConfiguration' object has no attribute 'duo_num'", 'timestamp': 1758986028}
2025-09-27 17:13:48,487 - {helpermodules.command:956} - {ERROR:Commands} - ERROR:helpermodules.command:{'Traceback (most recent call last):\n  File "/var/www/html/openWB/packages/helpermodules/command.py", line 156, in on_message\n    func(connection_id, payload)\n  File "/var/www/html/openWB/packages/helpermodules/command.py", line 827, in systemUpdate\n    cp.chargepoint.chargepoint_module.config.configuration.duo_num == 0,\nAttributeError: \'MqttConfiguration\' object has no attribute \'duo_num\'\n'}

Die all()-Funktion hat den Seiteneffekt, dass immer alle übergebenen Elemente geprüft werden. Die vorherige Implementierung hat die Prüfung aber sofort beendet, wenn external_openwb nicht gegeben war.
Das alte Verhalten ist doch gewünscht.

This reverts commit 51ea8ee.
@benderl benderl requested a review from ndrsnhs September 29, 2025 07:01
@benderl benderl self-assigned this Sep 29, 2025
@benderl benderl added the bug Something isn't working label Sep 29, 2025
@benderl benderl merged commit 9e97c8a into openWB:master Sep 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants