Skip to content

Koala Fixes #2793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benderl merged 2 commits into from
Sep 30, 2025
Merged

Koala Fixes #2793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f054c10
Koala: fix BaseCarousel resize handling
benderl Sep 30, 2025
d9e79e5
Koala: fix flow chart pv animation
benderl Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions packages/modules/web_themes/koala/source/src/components/BaseCarousel.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ function measure() {

onMounted(() => {
measure();
window.addEventListener('resize', measure);
window.addEventListener('resize', measure, {passive: true});
});

onBeforeUnmount(() => {
Expand All @@ -92,17 +92,17 @@ const groupSize = computed(() => {
const maxGroup = Math.max(
1,
Math.floor(
(carouselWidth.value - (showArrows.value ? carouselPadding.value : 50)) /
(carouselWidth.value - 2 - (showArrows.value ? carouselPadding.value : 50)) /
itemWidth.value,
),
);
// Spezialfall: Alle passen nebeneinander
if (
props.items.length > maxGroup &&
props.items.length <= maxGroup * 2 &&
props.items.length <= maxGroup + 1 &&
props.items.length - maxGroup === 1
) {
if (props.items.length * itemWidth.value <= carouselWidth.value) {
if (props.items.length * itemWidth.value < carouselWidth.value) {
return props.items.length;
}
}
Expand All @@ -126,6 +126,7 @@ watch(groupedItems, (groups) => {
if (currentSlide.value > groups.length - 1) {
currentSlide.value = Math.max(0, groups.length - 1);
}
measure();
});
</script>

Expand Down
8 changes: 6 additions & 2 deletions ...modules/web_themes/koala/source/src/components/charts/energyFlowChart/EnergyFlowChart.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,11 @@ const homeProduction = computed(() => Number(homePower.value.value) < 0);
const pvPower = computed(() => mqttStore.getPvPower('object') as ValueObject);
const pvProduction = computed(() => {
const value = Number(pvPower.value.value);
return Math.abs(value) >= 50;
return value < 0;
});
const pvConsumption = computed(() => {
const value = Number(pvPower.value.value);
return value > 0;
});

const connectedChargePoints = computed(() => mqttStore.chargePointIds);
Expand Down Expand Up @@ -284,7 +288,7 @@ const svgComponents = computed((): FlowComponent[] => {
base: 'pv',
valueLabel: 'fill-success',
animated: pvProduction.value,
animatedReverse: false,
animatedReverse: pvConsumption.value,
},
position: { row: 1, column: 0 },
label: ['PV', absoluteValueObject(pvPower.value).textValue],
Expand Down