Add surplus PV - Battery mode buttons to display#2803
Merged
LKuemmel merged 7 commits intoopenWB:masterfrom Oct 31, 2025
Merged
Add surplus PV - Battery mode buttons to display#2803LKuemmel merged 7 commits intoopenWB:masterfrom
LKuemmel merged 7 commits intoopenWB:masterfrom
Conversation
benderl
requested changes
Oct 13, 2025
Contributor
benderl
left a comment
There was a problem hiding this comment.
Die Verknküpfung mit der Batterie im Flow-Chart finde ich nicht gerade intuitiv, weil die aktuelle Einstellung des Modus dort nicht angezeigt wird. Ich würde nicht auf die Idee kommen, dass sich dahinter die Einstellungen der Batterie befinden. Der aktuelle Modus sollte irgendwie angezeigt werden, damit es intuitiver wird.
packages/modules/display_themes/cards/source/src/components/Battery/BatteryModeModal.vue
Show resolved
Hide resolved
packages/modules/display_themes/cards/source/src/components/Battery/BatteryModeModal.vue
Outdated
Show resolved
Hide resolved
Contributor
Author
Contributor
Author
benderl
approved these changes
Oct 22, 2025
Contributor
benderl
left a comment
There was a problem hiding this comment.
Kannst Du noch die Warnungen beheben?
Das Problem ist, dass modelValue als required: true definiert ist und trotzdem ein Standardwert angegeben ist. Letzterer wird demnach nie verwendet und kann entfallen.
c80986e to
723b15b
Compare
Contributor
Author
|
Standardwert angegeben entfernt von modelValue wenn required: true definiert ist |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Display Cards-Theme: im Energiefluss beim klicken auf Speicher den Speicher-Vorrang (EV, Speicher, Mindest-SoC) auswählen