Skip to content

improve error handling internal cp #2814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LKuemmel merged 1 commit into from
Oct 30, 2025
Merged

improve error handling internal cp #2814

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/modules/chargepoints/external_openwb/chargepoint_module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,10 @@ def on_message(client, userdata, message):
elif received_topics[f"{topic_prefix}fault_state"] == 1:
self.fault_state.warning(received_topics[f"{topic_prefix}fault_str"])
except KeyError:
raise KeyError("Es wurden nicht alle notwendigen Daten empfangen.")
if received_topics[f"{topic_prefix}fault_state"] == 2:
self.fault_state.error(received_topics[f"{topic_prefix}fault_str"])
else:
raise KeyError("Es wurden nicht alle notwendigen Daten empfangen.")
else:
self.fault_state.warning(f"Keine MQTT-Daten für Ladepunkt {self.config.name} empfangen. Noch keine "
"Daten nach dem Start oder Ladepunkt nicht erreichbar.")
Expand Down
10 changes: 5 additions & 5 deletions packages/modules/internal_chargepoint_handler/clients.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,16 +45,16 @@ def __init__(self,

def _evse_factory(self, client: Union[ModbusSerialClient_, ModbusTcpClient_], evse_ids: List[int]) -> evse.Evse:
for modbus_id in evse_ids:
evse_client = evse.Evse(modbus_id, client)
with client:
try:
try:
evse_client = evse.Evse(modbus_id, client)
with client:
if evse_client.get_firmware_version() > EVSE_MIN_FIRMWARE:
log.debug(client)
with ModifyLoglevelContext(log, logging.DEBUG):
log.debug("Modbus-ID der EVSE an LP"+str(self.local_charge_point_num)+": "+str(modbus_id))
return evse_client
except Exception:
pass
except Exception:
pass
else:
return None

Expand Down