Skip to content

fix sdm: legacy methods for smarthome #2876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LKuemmel merged 1 commit into from
Oct 30, 2025
Merged

fix sdm: legacy methods for smarthome #2876

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions packages/modules/common/sdm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
#!/usr/bin/env python3
from enum import IntEnum
import time
from typing import List, Tuple

from modules.common import modbus
from modules.common.abstract_counter import AbstractCounter
Expand All @@ -16,6 +18,11 @@ def __init__(self, modbus_id: int, client: modbus.ModbusTcpClient_) -> None:
with client:
self.serial_number = str(self.client.read_holding_registers(0xFC00, ModbusDataType.UINT_32, unit=self.id))

def get_imported(self) -> float:
# smarthome legacy
time.sleep(0.1)
return self.client.read_input_registers(0x0048, ModbusDataType.FLOAT_32, unit=self.id) * 1000


class SdmRegister(IntEnum):
VOLTAGE_L1 = 0x00
Expand All @@ -42,6 +49,13 @@ def __init__(self, modbus_id: int, client: modbus.ModbusTcpClient_, fault_state:
super().__init__(modbus_id, client)
self.fault_state = fault_state

def get_power(self) -> Tuple[List[float], float]:
# smarthome legacy
time.sleep(0.1)
powers = self.client.read_input_registers(0x0C, [ModbusDataType.FLOAT_32]*3, unit=self.id)
power = sum(powers)
return powers, power

def get_counter_state(self) -> CounterState:
resp = self.client.read_input_registers_bulk(
SdmRegister.VOLTAGE_L1, 76, mapping=self.REG_MAPPING, unit=self.id)
Expand Down Expand Up @@ -78,6 +92,12 @@ def __init__(self, modbus_id: int, client: modbus.ModbusTcpClient_, fault_state:
super().__init__(modbus_id, client)
self.fault_state = fault_state

def get_power(self) -> Tuple[List[float], float]:
# smarthome legacy
time.sleep(0.1)
power = self.client.read_input_registers(0x0C, ModbusDataType.FLOAT_32, unit=self.id)
return [power, 0, 0], power

def get_counter_state(self) -> CounterState:
resp = self.client.read_input_registers_bulk(
SdmRegister.VOLTAGE_L1, 76, mapping=self.REG_MAPPING, unit=self.id)
Expand Down