Merged
Conversation
Switch SMB connection from outdated NetBIOS/SMB1 (port 139) to direct TCP (port 445) Enable is_direct_tcp=True in SMBConnection for proper SMB2/3 support Remove dependency on NetBIOS session setup Improve security and compatibility with modern Samba/Windows servers Allow raising min protocol in smb.conf to SMB2 or SMB3 Refactor port handling and logging accordingly This update modernizes the backup upload mechanism and removes reliance on deprecated SMB1.
LKuemmel
requested changes
Dec 1, 2025
Contributor
LKuemmel
left a comment
LKuemmel
left a comment
There was a problem hiding this comment.
Mit dieser Implementierung wird zunächst der Upload über SMB2/3 ausgeführt, danach SMB1. Je nach Konfiguration wird mind. eines davon fehlschlagen, dh der Benutzer erhält immer eine Fehlermeldung. Wie wäre es, die beiden Varianten in einer if-Abfrage auszuführen und sich beim ersten erfolgreichen hochladen zu merken, ob SMB1 oder SMB2/3 verwendet werden muss?
Contributor
Author
|
Danke für den Hinweis, habe ich korrigiert. |
LKuemmel
requested changes
Dec 3, 2025
Contributor
LKuemmel
left a comment
LKuemmel
left a comment
There was a problem hiding this comment.
Bitte auch noch die Dateien aus .idea und inspectionProfiles, die nicht zum PR gehören, aus dem PR entfernen.
Co-authored-by: LKuemmel <76958050+LKuemmel@users.noreply.github.com>
Co-authored-by: LKuemmel <76958050+LKuemmel@users.noreply.github.com>
Co-authored-by: LKuemmel <76958050+LKuemmel@users.noreply.github.com>
Co-authored-by: LKuemmel <76958050+LKuemmel@users.noreply.github.com>
Co-authored-by: LKuemmel <76958050+LKuemmel@users.noreply.github.com>
Co-authored-by: LKuemmel <76958050+LKuemmel@users.noreply.github.com>
Contributor
|
Was ist mit dem suggested change https://github.com/openWB/core/pull/2981/files#r2583942139? Nicht einverstanden oder vergessen? |
LKuemmel
force-pushed
the
update_smb_backup
branch
from
014b727 to
08c6b0d
Compare
LKuemmel
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Samba upload to modern SMB2/SMB3 connection
is_direct_tcp=Truein SMBConnection for proper SMB2/3 supportmin protocolin smb.conf to SMB2 or SMB3This update modernizes the backup upload mechanism and removes reliance on deprecated SMB1.