Open
Conversation
benderl
force-pushed
the
feature-bat-control-simplify-activation
branch
from
2b07b52 to
c432d6a
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Dieses PR entfernt das MQTT-Topic openWB/bat/config/bat_control_permitted (inkl. Defaults, Verarbeitung, Tests und ACLs), sodass die aktive Speichersteuerung nicht mehr über ein separates “Disclaimer akzeptiert”-Flag freigeschaltet wird.
Changes:
- Entfernt
bat_control_permittedaus der Broker-/Datastore-Konfiguration (Validierung, Defaults, Upgrade-Pfad). - Entfernt Topic-Verarbeitung in
setdatasowie die entsprechende Konfigurations-Property und Logik inbat_all. - Aktualisiert Tests und Mosquitto DynSec ACL-Templates (inkl. ACL-Template-Version-Bump).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/helpermodules/update_config.py | Entfernt Topic aus valid/default topics und passt Datastore-Upgrade 86 an. |
| packages/helpermodules/setdata.py | Entfernt Handling des set/.../bat_control_permitted Topics. |
| packages/control/bat_all.py | Entfernt Config-Flag und Logikpfade, die von bat_control_permitted abhängig waren. |
| packages/control/bat_all_test.py | Entfernt Testparameter und Testfälle rund um bat_control_permitted. |
| data/config/mosquitto/public/default-dynamic-security.json | Entfernt ACLs für das Topic und bumped openwb-version (DynSec Template) zur ACL-Aktualisierung. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UI: openWB/openwb-ui-settings#958