Skip to content

feat(config)!: default allow_user_messages to multibot-mentions#1126

Merged
thepagent merged 4 commits into
mainfrom
feat/default-multibot-mentions
Jun 16, 2026
Merged

feat(config)!: default allow_user_messages to multibot-mentions#1126
thepagent merged 4 commits into
mainfrom
feat/default-multibot-mentions

Conversation

@chaodu-agent

@chaodu-agent chaodu-agent commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

Caution

BREAKING CHANGE — Changes the default value of allow_user_messages from "involved" to "multibot-mentions".

Motivation

In multi-bot deployments (which is the common setup for OpenAB), "involved" causes all bots to respond to every message in a shared thread. This is noisy and confusing. "multibot-mentions" is already the recommended mode in our docs for multi-bot setups, so making it the default aligns with best practice.

In single-bot threads, "multibot-mentions" behaves identically to "involved" — no user-facing change for single-bot deployments.

Migration

Existing deployments that rely on the old default and want all bots to respond in multi-bot threads without @mention should explicitly set:

allow_user_messages = "involved"

or in Helm:

agents:
  <name>:
    discord:
      allowUserMessages: "involved"

Changes

  • src/config.rs — move #[default] from Involved to MultibotMentions
  • docs/discord.md, docs/messaging.md, docs/config-reference.md — update default references
  • config.toml.example — update comments
  • charts/openab/values.yaml + templates/configmap.yaml — update Helm defaults and comments

Testing

  • Existing unit tests in src/discord.rs for multibot-mentions logic still pass (no default assertion existed).
  • Helm chart tests (configmap_test.yaml) test explicit values, not defaults — still pass.

BREAKING CHANGE: The default value of allow_user_messages is now
"multibot-mentions" instead of "involved". Existing deployments that
do not explicitly set this config will now require @mention in
multi-bot threads. To restore the previous behavior, explicitly set:

  allow_user_messages = "involved"

in your config.toml or Helm values.
@chaodu-agent chaodu-agent requested a review from thepagent as a code owner June 16, 2026 16:38
- Move #[default] in gateway Feishu AllowUsers enum
- Update FEISHU_ALLOW_USER_MESSAGES env var fallback
- Fix remaining 'involved (default)' references in messaging.md,
  discord.md, and feishu.md
- F1: fix outdated comment in messaging.md example block
- F2: remove duplicate multibot-mentions row in feishu.md table
- F3: fix FeishuConfig::default() hardcoded to Involved
@thepagent thepagent merged commit 0261cfc into main Jun 16, 2026
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants