feat(oabctl): fix bootstrap, create, apply, and exec commands#1160
Open
chaodu-agent wants to merge 23 commits into
Open
feat(oabctl): fix bootstrap, create, apply, and exec commands#1160chaodu-agent wants to merge 23 commits into
chaodu-agent wants to merge 23 commits into
Conversation
30d4d48 to
23dce45
Compare
This comment has been minimized.
This comment has been minimized.
- F1: SG creation now matches InvalidGroup.Duplicate specifically, propagates other errors - F2: CONFIG_B64 size check (8KB limit) with clear error message - F3: IAM role pre-flight validation before register_task_definition - F4: Replace too_many_arguments with ManifestParams struct
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
- Fix cp/sync broken by alias removal: use resolve_remote_path with dynamic ECS task lookup instead of ecsctl::alias::resolve_remote - Add --cluster/--namespace to Exec, Cp, Sync commands (default: oab/prod) - Update resolve_agent to accept cluster/namespace parameters - Handle iam:GetRole AccessDenied gracefully (warn + proceed)
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Cargo discovers the root Cargo.toml as workspace root and fails because operator is not listed as a member. Adding an empty [workspace] table makes operator a standalone package.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…refix
- resolve_agent: use 'oab-{namespace}-{name}' to match ecs_service_name()
- apply_ecs: load cluster from OabConfig instead of hardcoding 'oab'
Collaborator
Author
|
LGTM ✅ — Solid multi-faceted improvement to oabctl covering config injection, logging, IAM role validation, ECS Exec support, and dynamic task resolution. What This PR DoesFixes and improves multiple How It Works
Findings
What's Good (🟢)
Baseline Check
Minor Observations (non-blocking)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Multiple fixes and improvements to
oabctlCLI:Bootstrap
Create (
oabctl create)ghcr.io/openabdev/openab*) instead of ECRApply (
oabctl apply)CONFIG_B64) — noawsCLI needed in containerawslogslog configuration to container definitionwait_for_stable(better progress output, no 5-min timeout)Exec (
oabctl exec)oabctl exec kiro-demo -- bashfinds running task automaticallyOther
--clustertooabfor get/delete commandsBuild