Conversation
lishulong
requested review from
drmingdrmer,
liubaohai,
pengsven and
wenbobuaa
drmingdrmer
approved these changes
Oct 17, 2019
homework/lsl/proposer.py
Outdated
| # add 2 more to success more easily | ||
| majority_num = quorum + 2 | ||
| if majority_num > len(all_acceptors): | ||
| majority_num = len(all_acceptors) |
Author
There was a problem hiding this comment.
嗯，我把这个去掉吧
当时是为了测试一下多给几个acceptor发请求会快多少成功，是测试代码忘删了
drmingdrmer
requested changes
Dec 17, 2020
Member
drmingdrmer
left a comment
drmingdrmer
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @lishulong, @liubaohai, @pengsven, and @wenbobuaa)
homework/lsl/acceptor.py, line 10 at r1 (raw file):
logger = logging.getLogger(__name__)
wow. my first comment!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
homework: classic paxos demo
需求：
https://github.com/openacid/learn/wiki/homework-1-paxos-demo
This change is