feat: support max reasoning effort#546
Open
Nostereal wants to merge 2 commits into
Open
Conversation
provencher-oai
previously approved these changes
Jul 23, 2026
provencher-oai
left a comment
provencher-oai
left a comment
There was a problem hiding this comment.
Looks good but a few comments to look at
provencher-oai
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maxas a reasoning-effort value for compatible Codex modelsmaxis forwarded to app-serverturn/startThe plugin currently rejects
maxin its local allowlist before Codex can validate the selected model. This keeps model-specific compatibility enforcement in Codex app-server, consistent with the existing effort values.Testing
npm test(92 tests passed)