Skip to content

fix(tui): add missing Ctrl+n/Ctrl+p support to ListSelectionView #7629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
etraut-openai merged 5 commits into from
Dec 8, 2025
Merged

fix(tui): add missing Ctrl+n/Ctrl+p support to ListSelectionView #7629

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
51c20c3
feat(tui): add Ctrl+n/Ctrl+p navigation to selection popups
pppp606 Dec 5, 2025
a154d28
fix(tui): handle C0 control chars for Ctrl+n/Ctrl+p in selection popups
pppp606 Dec 5, 2025
02d80ff
refactor: remove Ctrl+n/Ctrl+p tests per review feedback
pppp606 Dec 6, 2025
506b149
Merge branch 'main' into feat/ctrl-np-navigation
pppp606 Dec 6, 2025
d7a471c
Merge branch 'main' into feat/ctrl-np-navigation
etraut-openai Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions codex-rs/tui/src/bottom_pane/list_selection_view.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,13 +264,36 @@ impl ListSelectionView {
impl BottomPaneView for ListSelectionView {
fn handle_key_event(&mut self, key_event: KeyEvent) {
match key_event {
// Some terminals (or configurations) send Control key chords as
// C0 control characters without reporting the CONTROL modifier.
// Handle fallbacks for Ctrl-P/N here so navigation works everywhere.
KeyEvent {
code: KeyCode::Up, ..
} => self.move_up(),
}
| KeyEvent {
code: KeyCode::Char('p'),
modifiers: KeyModifiers::CONTROL,
..
}
| KeyEvent {
code: KeyCode::Char('\u{0010}'),
modifiers: KeyModifiers::NONE,
..
} /* ^P */ => self.move_up(),
KeyEvent {
code: KeyCode::Down,
..
} => self.move_down(),
}
| KeyEvent {
code: KeyCode::Char('n'),
modifiers: KeyModifiers::CONTROL,
..
}
| KeyEvent {
code: KeyCode::Char('\u{000e}'),
modifiers: KeyModifiers::NONE,
..
} /* ^N */ => self.move_down(),
KeyEvent {
code: KeyCode::Backspace,
..
Expand Down
Loading