codex: isolate release recovery validation - #27
Merged
Conversation
The release recovery wrapper calls shared validators before checking its own saved source boundary. Those validators intentionally reuse shell variables while walking every pinned topic, so a later unstable row can overwrite source_base and make an exact recovery fail after canonical validation already passed. Run both read-only validators in subshells so their scratch variables cannot leak back into the recovery wrapper. Extend the recovery fixture with an unrelated unstable boundary so the regression fails without that isolation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The live no-push recovery preflight reached canonical validation, then the wrapper falsely reported a changed source boundary because shared validators reused the parent shell variable. Run those read-only validators in subshells so their scratch state cannot leak into the one-shot wrapper. The regression fixture now includes an unrelated unstable boundary that would trigger the clobber.
Tests: sh -n .github/workflows/codex-branch.sh; sh -n t/t9905-codex-branch.sh; git diff --check; t/t9905-codex-branch.sh --run=116-117 (117/117); exact live no-push preflight on meta 6e44c55 proposed only d8ddd6608e plus codex-pins/40589.