fix(completion): stop fish from writing debug logs#22
Closed
jeet-dekivadia wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Jeet Dekivadia <jeet.university@gmail.com>
Author
|
Closing in favor of #21, which now includes this fish stderr fix together with focused regression coverage so reviewers have one cohesive completion-hygiene patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/tmp/fish-debug.logWhy
The fish completion script currently writes diagnostics from every tab-completion invocation to a fixed temporary file. That leaves an unbounded, cross-session debug log behind during normal CLI usage and can retain command diagnostics unexpectedly. Bash already suppresses the same internal probe's stderr; fish should do the same.
Validation
git diff --checkgo test ./internal/autocomplete -count=1fish-debug