[codex] Fix CLI argparse type mismatches in opf.__main__#3
Open
romgenie wants to merge 1 commit intoopenai:mainfrom
Open
[codex] Fix CLI argparse type mismatches in opf.__main__#3romgenie wants to merge 1 commit intoopenai:mainfrom
romgenie wants to merge 1 commit intoopenai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normalizes
Sequence[str]inputs tolist[str]before forwarding them into parser helpers inopf/__main__.py.This fixes
pyright/Pylance argument type errors in the unified CLI entrypoint without changing runtime behavior.Changes
argvtolist[str] | Noneinsideopf.__main__.py:parse_argsbefore callingArgumentParser.parse_argsargvtolist[str]in theopf eval --helpdispatch path before callingopf._eval.args.parse_argsWhy
opf.__main__acceptsSequence[str]for convenience, but the parser helpers it calls are typed as acceptinglist[str] | None. That produced a static type error in Pylance/pyright even though runtime behavior was fine.This keeps the public wrapper signatures unchanged and normalizes at the call boundary.
Verification
Result: