Conversation
moved matplotlib-base to conda dependencies because does not exist in pip
Closed
pradal
requested changes
Sep 5, 2025
pyproject.toml
Outdated
| dependencies = [ | ||
| "openalea.plantgl", | ||
| "openalea.lpy" | ||
| "openalea.lpy", |
Contributor
There was a problem hiding this comment.
lpy is not mandatory.
Remove it. We want lpy only when we wante to convert mtg 2 lpy and lpy 2 mtg.
Otherelse, just pure Python!!!
only necessary when converting mtg 2 lpy and lpy 2 mtg
pradal
approved these changes
Sep 5, 2025
Contributor
|
However, you need openalea.lpy for one test... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
linked to issue #61 also
I moved matplotlib-base to conda dependencies because it is not in pypi. That does not change things for CI because it is always the conda pkg, but when running
conda env create - environment.ymlwill stop with error.