Skip to content

feat(spindle-ui): add Tooltip component#1695

Draft
yu-3in wants to merge 12 commits intomainfrom
feature/tooltip
Draft

feat(spindle-ui): add Tooltip component#1695
yu-3in wants to merge 12 commits intomainfrom
feature/tooltip

Conversation

@yu-3in
Copy link
Copy Markdown
Contributor

@yu-3in yu-3in commented Dec 9, 2025

#1642 の実装です。

TODO

  • 閉じるボタンのサイズがFigmaと違いそう。場合によってはIconButtonを使う方針をとる
  • Animation Tokenの利用について適切かどうか
  • arrowは擬似要素自体を回転させることで使い回しできないか
  • JSロジックの確認、テストケースの確認、リファクタリング
  • TriggerPropsは展開した方が利用側の体験良さそう
    • 展開しない場合見にくい:スクリーンショット 2025-12-10 午後6 28 18

@yu-3in yu-3in self-assigned this Dec 9, 2025
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Dec 9, 2025

⚠️ No Changeset found

Latest commit: f9286f8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@yu-3in yu-3in changed the base branch from main to docs/tooltip December 9, 2025 03:18
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 9, 2025

Visit the preview URL for this PR (updated for commit f9286f8):

https://ameba-spindle--pr1695-feature-tooltip-k2a6wu6c.web.app

(expires Fri, 15 May 2026 05:34:27 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e7521619a2dd5c653490c8246e81ec2a5c8f1435

@reg-suit
Copy link
Copy Markdown

reg-suit bot commented Dec 9, 2025

reg-suit detected visual differences.

Check this report, and review them.

🔴 Changed ⚪ New 🔵 Passing
2 16 256
How can I change the check status? If reviewers approve this PR, the reg context status will be green automatically.

Base automatically changed from docs/tooltip to main December 22, 2025 01:51
yu-3in added 4 commits April 15, 2026 14:21
他コンポーネントの慣習に合わせ、animation tokenのCSS変数参照を
値の直接記述に変更。index.cssからspindle-tokensのimportを除外。
- appear-in: 0.35s cubic-bezier(0.5, 0, 0.5, 1)
- disappear: 0.15s cubic-bezier(0.5, 0, 0.5, 1)
- @jest/globalsをvitestのviに置き換え
- モバイルの矢印サイズをFigmaに合わせて調整
  (arrow-size: 11→14px, arrow-depth: 6→8px, arrow-offset: 4→2px)
タッチデバイスでは機能を持つボタンをトリガーにすると
本来の機能が動作しない問題をDO NOTセクションに記載。
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant