Skip to content

InlineDropDownのDesignDocを追加#1740

Merged
tokimari merged 6 commits intomainfrom
codex/create-design-doc-for-inlinedropdown
Apr 2, 2026
Merged

InlineDropDownのDesignDocを追加#1740
tokimari merged 6 commits intomainfrom
codex/create-design-doc-for-inlinedropdown

Conversation

@tokimari
Copy link
Copy Markdown
Contributor

@tokimari tokimari commented Dec 26, 2025 •
edited
Loading

InlineDropDownのDesignDocを追加しました。

Summary

#1740 (comment) についてどうすべきかわからなかったので途中経過でPRしました 🙏

Testing

  • Not run (not requested)

Codex使いながら度々フリーズしてしまって面倒になったので一旦push・・追加修正入れます 🙇

Codex Task

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Dec 26, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0813905

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tokimari tokimari changed the title InlineDropDownのDOにタップターゲットの確保を追記 InlineDropDownのDesignDocを追加 Dec 26, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 26, 2025 •
edited
Loading

Visit the preview URL for this PR (updated for commit 0813905):

https://ameba-spindle--pr1740-codex-create-design-glg1llrx.web.app

(expires Sat, 02 May 2026 00:20:38 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e7521619a2dd5c653490c8246e81ec2a5c8f1435

@reg-suit
Copy link
Copy Markdown

reg-suit bot commented Dec 26, 2025 •
edited
Loading

reg-suit detected visual differences.

Check this report, and review them.

🔴 Changed 🔵 Passing
2 256
How can I change the check status? If reviewers approve this PR, the reg context status will be green automatically.

tokimari
tokimari commented Dec 26, 2025
View reviewed changes
Comment thread packages/spindle-ui/src/Form/InlineDropDown/design-doc.md
tokimari
tokimari commented Dec 26, 2025
View reviewed changes
Comment thread packages/spindle-ui/src/Form/InlineDropDown/design-doc.md Outdated
tokimari
tokimari commented Dec 26, 2025
View reviewed changes
Comment thread packages/spindle-ui/src/Form/InlineDropDown/design-doc.md Outdated
tokimari
tokimari commented Dec 26, 2025
View reviewed changes
Comment thread packages/spindle-ui/src/Form/InlineDropDown/design-doc.md
@tokimari tokimari requested review from a team, herablog, tatz012 and yasuda-shin and removed request for a team December 26, 2025 06:58
@tokimari tokimari self-assigned this Dec 26, 2025
@tokimari tokimari requested a review from yu-3in December 26, 2025 06:58
yasuda-shin
yasuda-shin reviewed Dec 26, 2025
View reviewed changes
Comment thread packages/spindle-ui/src/Form/InlineDropDown/design-doc.md Outdated

InlineDropDownは試験的なコンポーネントであるため、破壊的な変更や削除等おこなわれる可能性があることに注意して利用してください。

## スクリーンショット
Copy link
Copy Markdown
Contributor

@yasuda-shin yasuda-shin Dec 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

スクリーンショットは追加します？

Copy link
Copy Markdown
Member

@herablog herablog Dec 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

なければ無理に追加しなくても大丈夫ではあります

Copy link
Copy Markdown
Member

@herablog herablog Dec 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

その場合は見出しを削除していただいて大丈夫です！

Copy link
Copy Markdown
Contributor Author

@tokimari tokimari Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

見出し削除しました 🙏
2bfcfe2

@tokimari tokimari force-pushed the codex/create-design-doc-for-inlinedropdown branch from 2360f05 to 048b48d Compare February 12, 2026 07:37
@tokimari tokimari requested a review from yasuda-shin February 12, 2026 07:38
@tokimari tokimari marked this pull request as draft February 13, 2026 02:03
@tokimari tokimari force-pushed the codex/create-design-doc-for-inlinedropdown branch from 611df05 to 0813905 Compare April 2, 2026 00:19
@tokimari tokimari marked this pull request as ready for review April 2, 2026 00:44
@tokimari
Copy link
Copy Markdown
Contributor Author

tokimari commented Apr 2, 2026

@yasuda-shin @herablog 再レビューお願いします 🙏 （お久しぶりです 😇 ）

@tokimari tokimari merged commit 5d3b20f into main Apr 2, 2026
11 checks passed
@tokimari tokimari deleted the codex/create-design-doc-for-inlinedropdown branch April 2, 2026 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yasuda-shin yasuda-shin yasuda-shin approved these changes

@herablog herablog Awaiting requested review from herablog herablog was automatically assigned from openameba/spindle-working-group

@tatz012 tatz012 Awaiting requested review from tatz012 tatz012 was automatically assigned from openameba/spindle-working-group

@yu-3in yu-3in Awaiting requested review from yu-3in

Assignees

@tokimari tokimari

Labels

codex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tokimari @herablog @yasuda-shin