-
Notifications
You must be signed in to change notification settings - Fork 42
feat(observability): make project-level log component names clickable #643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kavix
wants to merge
11
commits into
openchoreo:main
Choose a base branch
from
kavix:feat/clickable-log-components
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
73b246c
feat(observability): add clickable link to component name in logs
kavix 49502d1
test(observability): update LogEntry tests with MemoryRouter
kavix f1d26ab
chore(observability): add changeset for clickable log components
kavix 913888c
fix(observability): use dynamic namespace and kind in log component l…
kavix 6c65bd1
refactor(observability): reuse buildRuntimeLogsBasePath to derive log…
kavix 6ff1b71
test(openchoreo): fix failing tests and suppress JSDOM console warnin…
kavix ddda7aa
DCO
kavix 73a9f86
test(observability): assert link click navigation and propagation sto…
kavix f699bad
chore: update yarn.lock to resolve @backstage/backend-test-utils@1.11.4
kavix a58cc94
chore: refresh yarn.lock - remove stale @backstage/backend-test-utils…
kavix 3bbf3b8
style: fix prettier formatting in setupTests.ts
kavix File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@openchoreo/backstage-plugin-openchoreo-observability': minor | ||
| --- | ||
|
|
||
| Made component names in the project-level logging view clickable, allowing users to navigate directly to the component-scoped logging view while preserving the current time range and any relevant filters. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,32 @@ | ||
| /* eslint-disable no-console */ | ||
| import '@testing-library/jest-dom'; | ||
|
|
||
| (globalThis as any).IS_REACT_ACT_ENVIRONMENT = true; | ||
| if (typeof window !== 'undefined') { | ||
| (window as any).IS_REACT_ACT_ENVIRONMENT = true; | ||
| } | ||
| if (typeof global !== 'undefined') { | ||
| (global as any).IS_REACT_ACT_ENVIRONMENT = true; | ||
| } | ||
|
|
||
| const originalConsoleError = console.error; | ||
| console.error = (...args: any[]) => { | ||
| if ( | ||
| typeof args[0] === 'string' && | ||
| (args[0].includes('Could not parse CSS stylesheet') || | ||
| args[0].includes('css parsing') || | ||
| args[0].includes('not configured to support act')) | ||
| ) { | ||
| return; | ||
| } | ||
| if ( | ||
| args[0] && | ||
| typeof args[0] === 'object' && | ||
| (args[0].message?.includes('Could not parse CSS stylesheet') || | ||
| args[0].type === 'css parsing' || | ||
| args[0].message?.includes('not configured to support act')) | ||
| ) { | ||
| return; | ||
| } | ||
| originalConsoleError(...args); | ||
| }; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.