feat: extract portal packages (portal-backend and portal-app) - #707
Merged
kaviththiranga merged 3 commits intoJul 28, 2026
Merged
Conversation
Move the backend composition into the published @openchoreo/backstage-portal-backend (feature bundle + IDP root-router factory) and the app shell into the private @openchoreo/backstage-portal-app (createPortalApp); app and backend are now thin consumers. Behavior unchanged. Part of openchoreo/openchoreo#4330 Signed-off-by: Kavith Lokuhewage <kaviththiranga@gmail.com>
kaviththiranga
requested review from
Mirage20,
sameerajayasoma and
stefinie123
as code owners
July 27, 2026 09:05
|
Important Review skippedToo many files! This PR contains 220 files, which is 120 over the limit of 100. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (220)
You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Express the backend composition as data (service factories + lazy import thunks) so tests can assert it without booting plugins; behavior unchanged. Part of openchoreo/openchoreo#4330 Signed-off-by: Kavith Lokuhewage <kaviththiranga@gmail.com>
stefinie123
previously approved these changes
Jul 27, 2026
With gcTime 0 the unobserved entry is evicted on a setTimeout(0), so the second fetchQuery raced the GC timer under CI load. Fake timers keep the timer pending so the test asserts the staleTime contract deterministically. Signed-off-by: Kavith Lokuhewage <kaviththiranga@gmail.com>
stefinie123
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the backend composition into the published
@openchoreo/backstage-portal-backend (feature bundle + IDP root-router factory) and the app shell into the private
@openchoreo/backstage-portal-app (createPortalApp); app and backend are now thin consumers. Behavior unchanged.
Part of openchoreo/openchoreo#4330