Skip to content

chore: remove obsolete maintenance helpers - #37

Merged
steipete merged 1 commit into
mainfrom
codex/maintenance-cleanup
Aug 13, 2026
Merged

chore: remove obsolete maintenance helpers#37
steipete merged 1 commit into
mainfrom
codex/maintenance-cleanup

Conversation

@steipete

Copy link
Copy Markdown
Collaborator

Summary

  • Remove three unreferenced root helpers that respectively killed every Swift/SourceKit process, depended on a personal absolute path, or targeted a nonexistent nested build directory.
  • Remove the uncompiled UsingNewImprovements.swift example after verifying that it has drifted from current public APIs; maintained examples remain in the README.
  • Keep the public legacy traversal compatibility tests while narrowly marking those test functions deprecated so expected API warnings do not flood every build.
  • Reconcile the Unreleased changelog with the one-pass universal build and consolidated observation registry that are already on main.

Proof

  • swift test (111 tests; no deprecated-declaration warnings)
  • make check (SwiftFormat, strict SwiftLint, native-only implementation and policy gates)
  • shellcheck scripts/*.sh
  • swift build -c release --product axorc
  • scripts/build-release-artifact.sh 0.1.6 --adhoc
  • Verified archive contents, SHA-256, x86_64 arm64 architectures, code signature, and axorc --version
  • P0-P2 autoreview: clean

@clawsweeper

clawsweeper Bot commented Aug 13, 2026

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

@cursor

cursor Bot commented Aug 13, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Documentation and test-annotation changes plus removal of unreferenced scripts; no production library or CLI behavior changes in the diff.

Overview
Removes unreferenced maintenance artifacts: root scripts that killed all Swift processes, invoked axorc via a hard-coded personal path, or assumed a fixed debug build layout, plus the uncompiled UsingNewImprovements.swift example that no longer matches public APIs (README examples remain).

Tests: legacy traversal compatibility tests are kept but their two functions are marked @available(*, deprecated) so exercising deprecated globals does not flood every build with warnings.

Changelog: the Unreleased Fixed section is updated to document the one-pass universal release build and consolidated observation token registry already on main, replacing the older single-architecture build-directory wording.

Reviewed by Cursor Bugbot for commit edd4a24. Bugbot is set up for automated code reviews on this repo. Configure here.

@clawsweeper clawsweeper Bot added P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels Aug 13, 2026
@clawsweeper

clawsweeper Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codex review: needs maintainer review before merge. Reviewed August 13, 2026, 6:16 AM ET / 10:16 UTC.

ClawSweeper review

What this changes

The PR removes three obsolete root helpers and an uncompiled, outdated example, marks two legacy-API test functions deprecated, and aligns unreleased notes with current release tooling.

Merge readiness

⚠️ Ready for maintainer review - 2 items remain

Keep open for normal collaborator review: the scoped cleanup has no supported-path regression or actionable patch defect in the reviewed source. Likely related person: steipete (high confidence, recent release, observation, and traversal work).

Priority: P3
Reviewed head: edd4a245b8175ff9c8e333da9deafde736b173c5
Owner decision: Required. See Decision needed.

Review scores

Measure Result What it means
Overall readiness 🐚 platinum hermit (4/6) A focused, coherent cleanup with maintained alternatives verified in current source and no actionable review findings.
Proof confidence 🌊 off-meta tidepool Not applicable: This collaborator-authored maintenance PR is outside the external-contributor proof gate; its body also records local test, lint, shell, build, and artifact checks.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Verification

Check Result Evidence
Real behavior Not applicable Not applicable: This collaborator-authored maintenance PR is outside the external-contributor proof gate; its body also records local test, lint, shell, build, and artifact checks.
Evidence reviewed 5 items Uncompiled example and maintained alternatives: SwiftPM declares only Sources/AXorcist, Sources/axorc, and Tests targets, not Examples; the README documents both Homebrew and source installation, while the Makefile invokes the maintained universal-build script.
No supported references to deleted helpers: A tracked-tree search on current main found no references to the three root helpers or the removed example outside the example file itself; current release tooling is scripts/build-universal-binary.sh and scripts/build-release-artifact.sh.
Legacy coverage remains intact: The two modified tests still exercise the deprecated traversal defaults, and current source intentionally retains those globals as public deprecated compatibility APIs.
Findings None None.
Security None None.

How this fits together

AXorcist is a macOS accessibility library with an axorc command-line tool. The removed repository helpers sit outside SwiftPM targets, while the maintained build scripts, README examples, tests, and release notes guide developers and package the CLI.

flowchart LR
A[Developer commands] --> B[Maintained build scripts]
C[README examples] --> D[AXorcist library and CLI]
E[Compatibility tests] --> D
B --> F[Universal release artifact]
D --> F
Loading

Decision needed

Question Recommendation
Should this collaborator-authored maintenance cleanup merge once the normal build-and-lint check completes? Merge the cleanup: Approve the removal after the normal check verifies the current head.

Why: The patch appears correct, but collaborator-authored items require explicit maintainer judgment rather than automated closure or merge.

Before merge

  • Complete next step (P2) - No mechanical repair is needed; explicit collaborator maintainer approval is the remaining action.
Agent review details

Security

None.

Review metrics

Metric Value Why it matters
Maintenance surface 6 files; +4 / -423 lines The diff removes three root helpers and one uncompiled example while leaving library and CLI implementation paths unchanged.

Technical review

Best possible solution:

Keep the maintained build scripts and README examples as the supported developer paths, while removing the unreferenced local helpers and stale standalone example.

Do we have a high-confidence way to reproduce the issue?

Not applicable: this PR removes repository-maintenance artifacts rather than fixing a reported runtime failure.

Is this the best way to solve the issue?

Yes: the retained Makefile/scripts and README are the current supported paths, so deleting unreferenced local helpers and an uncompiled example is the narrowest maintainable cleanup.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against cbec42494cc0.

Labels

Label changes:

  • add P3: This is a small repository-maintenance cleanup with no identified production behavior regression.
  • add rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: This collaborator-authored maintenance PR is outside the external-contributor proof gate; its body also records local test, lint, shell, build, and artifact checks.

Label justifications:

  • P3: This is a small repository-maintenance cleanup with no identified production behavior regression.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: This collaborator-authored maintenance PR is outside the external-contributor proof gate; its body also records local test, lint, shell, build, and artifact checks.

Evidence

What I checked:

  • Uncompiled example and maintained alternatives: SwiftPM declares only Sources/AXorcist, Sources/axorc, and Tests targets, not Examples; the README documents both Homebrew and source installation, while the Makefile invokes the maintained universal-build script. (Package.swift:33, cbec42494cc0)
  • No supported references to deleted helpers: A tracked-tree search on current main found no references to the three root helpers or the removed example outside the example file itself; current release tooling is scripts/build-universal-binary.sh and scripts/build-release-artifact.sh. (scripts/build-universal-binary.sh:39, cbec42494cc0)
  • Legacy coverage remains intact: The two modified tests still exercise the deprecated traversal defaults, and current source intentionally retains those globals as public deprecated compatibility APIs. (Sources/AXorcist/Search/AXTraversalOptions.swift:37, cbec42494cc0)
  • Current-main provenance and ownership: Blame assigns the affected traversal tests to f9a9206, and current main's release and observation changes are cbec424 and 03a6d95, all authored by Peter Steinberger; the PR is based directly on current main and is not yet in a release. (Tests/AXorcistTests/TraversalOptionsTests.swift:21, f9a92067)
  • Repository policy: The full root policy asks for minimal AXorcist changes and only calls for Peekaboo synchronization when a submodule is bumped; this PR does not touch a submodule. (AGENTS.md:1, cbec42494cc0)

Likely related people:

  • steipete: Current main history and blame attribute the central release, observation, and traversal surfaces to Peter Steinberger, who is also the collaborator author of this focused cleanup. (role: recent release, observation, and traversal contributor; confidence: high; commits: cbec42494cc0, 03a6d9516fe0, f9a92067; files: scripts/build-universal-binary.sh, Tests/AXorcistTests/TraversalOptionsTests.swift, CHANGELOG.md)

Rating scale

Score Internal tier Crab rank Meaning
6/6 S 🦀 challenger crab Exceptional readiness
5/6 A 🦞 diamond lobster Very strong readiness
4/6 B 🐚 platinum hermit Good normal PR; ordinary maintainer review
3/6 C 🦐 gold shrimp Useful, but confidence is limited
2/6 D 🦪 silver shellfish Proof or implementation needs work
1/6 F 🧂 unranked krab Not merge-ready
N/A NA 🌊 off-meta tidepool Rating does not apply

Overall follows the weaker of proof and patch quality.
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

Workflow

  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

@steipete
steipete merged commit 2f49038 into main Aug 13, 2026
7 checks passed
@steipete
steipete deleted the codex/maintenance-cleanup branch August 13, 2026 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant