chore: remove obsolete maintenance helpers - #37
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
PR SummaryLow Risk Overview Tests: legacy traversal compatibility tests are kept but their two functions are marked Changelog: the Unreleased Fixed section is updated to document the one-pass universal release build and consolidated observation token registry already on Reviewed by Cursor Bugbot for commit edd4a24. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
Codex review: needs maintainer review before merge. Reviewed August 13, 2026, 6:16 AM ET / 10:16 UTC. ClawSweeper reviewWhat this changesThe PR removes three obsolete root helpers and an uncompiled, outdated example, marks two legacy-API test functions deprecated, and aligns unreleased notes with current release tooling. Merge readinessKeep open for normal collaborator review: the scoped cleanup has no supported-path regression or actionable patch defect in the reviewed source. Likely related person: steipete (high confidence, recent release, observation, and traversal work). Priority: P3 Review scores
Verification
How this fits togetherAXorcist is a macOS accessibility library with an flowchart LR
A[Developer commands] --> B[Maintained build scripts]
C[README examples] --> D[AXorcist library and CLI]
E[Compatibility tests] --> D
B --> F[Universal release artifact]
D --> F
Decision needed
Why: The patch appears correct, but collaborator-authored items require explicit maintainer judgment rather than automated closure or merge. Before merge
Agent review detailsSecurityNone. Review metrics
Technical reviewBest possible solution: Keep the maintained build scripts and README examples as the supported developer paths, while removing the unreferenced local helpers and stale standalone example. Do we have a high-confidence way to reproduce the issue? Not applicable: this PR removes repository-maintenance artifacts rather than fixing a reported runtime failure. Is this the best way to solve the issue? Yes: the retained Makefile/scripts and README are the current supported paths, so deleting unreferenced local helpers and an uncompiled example is the narrowest maintainable cleanup. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against cbec42494cc0. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
Summary
UsingNewImprovements.swiftexample after verifying that it has drifted from current public APIs; maintained examples remain in the README.main.Proof
swift test(111 tests; no deprecated-declaration warnings)make check(SwiftFormat, strict SwiftLint, native-only implementation and policy gates)shellcheck scripts/*.shswift build -c release --product axorcscripts/build-release-artifact.sh 0.1.6 --adhocx86_64 arm64architectures, code signature, andaxorc --version