docs: design bounded hosted live smoke tier - #1195
Conversation
|
Codex review: found issues before merge. Reviewed August 8, 2026, 9:43 PM ET / August 9, 2026, 01:43 UTC. ClawSweeper reviewWhat this changesThe PR adds a design for a budget-bounded DigitalOcean and Scaleway hosted live-smoke tier and links it from the existing provider live-smoke guide. Merge readinessKeep open: this is a useful bounded hosted-smoke design, but its unchanged sweeper policy conflicts with Crabbox’s durable-claim deletion contract and needs a security/operations decision before it can become repository guidance. Priority: P2 Review scores
Verification
How this fits togetherProvider live-smoke documentation defines how Crabbox adapters are validated from hermetic tests through opt-in real-provider checks. This proposal would govern a future scheduled credentialed tier that creates provider resources and must safely clean them up. flowchart TD
A[Provider adapter] --> B[Guarded live smoke]
B --> C[Hosted smoke policy]
C --> D[Protected trigger and credentials]
D --> E[Provider resource]
E --> F[Cleanup job]
C --> G[Durable ownership claim]
G --> F
F --> H[Independent sweeper]
Decision needed
Why: The claim store and operational ownership of a funded destructive sweeper are security and operations policy choices that the documentation cannot safely infer. Before merge
Findings
Agent review detailsSecurityNeeds attention: The documentation introduces a future destructive-sweeper policy that lacks the durable claim required by the repository’s ownership boundary. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Revise the design to require a cancellation-surviving durable claim bound to the exact provider, project, and resource before any sweeper deletion, then obtain explicit approval for the funded operational tier. Do we have a high-confidence way to reproduce the issue? Not applicable: this is a documentation-only proposal; current-source comparison nevertheless confirms that its proposed deletion rule conflicts with the existing claim-gated contract. Is this the best way to solve the issue? No. A durable claim that survives runner cancellation is needed before provider tags and project membership can authorize destructive sweeping. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against ce9487f55205. LabelsLabel changes:
Label justifications:
EvidenceSecurity concerns:
What I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (58 earlier review cycles; latest 8 shown)
|
Summary
live-smokeprotected-environment boundary, schedule/manual-only triggers, main-only checkout guards, least-privilege provisioning and sweeper credentials, rotation policy, and the required-reviewer tradeoff for scheduled reconciliationThis is the design-only tier-two follow-up for #944. It builds on the hermetic lifecycle gate from #948, the secretless hosted end-to-end tier from #981, and the provider-specific live-test documentation work in #979.
Verification
No live provider proof applies: this is a documentation-only proposal, deliberately adds no active workflow, and performs no provider mutation. The generated
dist/docs-siteartifact was removed after validation.Security and activation
No repository or environment secret is added or referenced by executable code. The proposal keeps all future funded credentials inside the
live-smokeenvironment and blocks activation until dedicated provider projects, hard caps, separately scoped sweepers, destructive canary proof, shape tests, and the maintainer checklist are complete.No changelog entry: documentation-only design proposal, as requested.