Skip to content

fix: bind product apex routes#19

Merged
steipete merged 1 commit into
mainfrom
codex/product-www-route
Jun 12, 2026
Merged

fix: bind product apex routes#19
steipete merged 1 commit into
mainfrom
codex/product-www-route

Conversation

@steipete

Copy link
Copy Markdown
Contributor

Summary

Bind both crabfleet.ai/* and www.crabfleet.ai/* directly in the source-controlled product Worker config.

Production verification after #18 showed the apex route using the new product router, while www could still bypass it and reach GitHub Pages directly.

Verification

  • pnpm check
  • pnpm test (45 tests)
  • pnpm deploy:product --dry-run
  • git diff --check
  • autoreview clean: no accepted/actionable findings

@steipete steipete merged commit 772b92a into main Jun 12, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cc93769c0e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread wrangler.product.jsonc
Comment on lines +8 to +10
"routes": [
{ "pattern": "crabfleet.ai/*", "zone_name": "crabfleet.ai" },
{ "pattern": "www.crabfleet.ai/*", "zone_name": "crabfleet.ai" },

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use the DNS-scoped token for product routes

In deployments that follow the documented secret split, CLOUDFLARE_API_TOKEN only has Workers/D1 deploy permissions while crabfleet.ai DNS/route permissions live in CLOUDFLARE_DNS_API_TOKEN (README.md lines 136-141, workflow lines 56-88). Putting these routes in wrangler.product.jsonc makes the earlier pnpm deploy:product step try to upsert Workers Routes in the crabfleet.ai zone before the DNS-scoped Ensure domains step can create the same routes, so CI will fail for the documented setup; keep route creation in the convergence script or deploy this config with the DNS-scoped token.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant