docs(config): drop nonexistent --tag flag from config add reference - #312
docs(config): drop nonexistent --tag flag from config add reference#312KrasimirKralev wants to merge 1 commit into
Conversation
The 'mcporter config add' flag list in docs/config.md includes '--tag', but extractAddFlags (src/cli/config/add.ts) has no --tag case: unknown flags fall through the default branch and are silently skipped. The canonical help output (src/cli/config/help.ts) omits it, and no tag/tags field exists in config-schema.ts, config-normalize.ts, or definition-fields.ts. Following the doc silently drops the value.
|
🦞👀 Pull request received. I will update this pull request when review starts. |
|
Codex review: needs maintainer review before merge. Reviewed August 13, 2026, 4:31 PM ET / 20:31 UTC. ClawSweeper reviewWhat this changesThe PR removes the nonexistent Merge readinessKeep this PR open for ordinary documentation review. The one-line diff is internally consistent with the supplied parser/help audit and the prior review found no defect, but this review environment could not run read-only repository commands to independently verify current-main source or history. Priority: P3 Review scores
Verification
How this fits togetherMCPorter’s configuration CLI turns flowchart LR
A[Configuration guide] --> B[User command]
B --> C[Configuration CLI]
C --> D[Argument parsing]
D --> E[Saved server definition]
Before merge
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Land the focused documentation correction if a refreshed current-main source check confirms that Do we have a high-confidence way to reproduce the issue? Not applicable: this is a docs-only correction. The supplied PR body gives a static parser/help comparison, but a current-main source check could not be run in this environment. Is this the best way to solve the issue? Unclear: removing the option is the narrowest apparent solution, but the parser and help claims need a refreshed current-main verification before merge. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 082d790a5817. LabelsLabel justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (1 earlier review cycle)
|
Summary
docs/config.mdlists--tagin themcporter config addflag reference, but no such flag exists in the CLI.--tag <value>gets it silently dropped —extractAddFlagsroutes unknown tokens through itsdefault:branch (index += 1; break;), so--tag foois skipped with no error and no effect. Silent no-op on a documented flag.`--tag`token from the flag list indocs/config.md(docs-only, +1/−1).--tagcase never existed, so nothing runtime is added or removed. Every other flag on that line (--env,--header,--token-cache-dir,--description,--client-name,--oauth-redirect-url) has a real handler and is left intact.Linked context
config addreference against the parser.Evidence
The documented flag list vs. the actual parser cases in
src/cli/config/add.ts(extractAddFlags):There is no
--tagcase; unknown flags hit thedefault:branch and are silently skipped. The canonical help output (src/cli/config/help.ts) omits--tag, and notag/tagsfield exists inconfig-schema.ts,config-normalize.ts, ordefinition-fields.ts. The onlytag/tagssymbols in the tree are unrelated display labels insrc/cli/list-format.ts.Generated by Claude Code