Skip to content

docs(config): drop nonexistent --tag flag from config add reference - #312

Draft
KrasimirKralev wants to merge 1 commit into
openclaw:mainfrom
KrasimirKralev:docs/scout-d-2026-08-10
Draft

docs(config): drop nonexistent --tag flag from config add reference#312
KrasimirKralev wants to merge 1 commit into
openclaw:mainfrom
KrasimirKralev:docs/scout-d-2026-08-10

Conversation

@KrasimirKralev

Copy link
Copy Markdown
Contributor

Summary

  • Problem: docs/config.md lists --tag in the mcporter config add flag reference, but no such flag exists in the CLI.
  • Why it matters: A user following the docs and passing --tag <value> gets it silently dropped — extractAddFlags routes unknown tokens through its default: branch (index += 1; break;), so --tag foo is skipped with no error and no effect. Silent no-op on a documented flag.
  • What changed: Remove the `--tag` token from the flag list in docs/config.md (docs-only, +1/−1).
  • What did NOT change (scope boundary): No parser, schema, help text, or config-shape change — the --tag case never existed, so nothing runtime is added or removed. Every other flag on that line (--env, --header, --token-cache-dir, --description, --client-name, --oauth-redirect-url) has a real handler and is left intact.

Linked context

  • Related: N/A — docs-correctness fix found while auditing the config add reference against the parser.
  • Requested by a maintainer/owner? No — investigated from the docs/source mismatch.

Evidence

The documented flag list vs. the actual parser cases in src/cli/config/add.ts (extractAddFlags):

$ grep -n "case '--" src/cli/config/add.ts
      case '--transport':
      case '--url':
      case '--command':
      case '--stdio':
      case '--arg':
      case '--args':
      case '--description':
      case '--env':
      case '--header':
      case '--token-cache-dir':
      case '--client-name':
      case '--oauth-client-id':
      case '--oauth-client-secret-env':
      case '--oauth-token-endpoint-auth-method':
      case '--oauth-redirect-url':
      case '--auth':
      case '--copy-from':
      case '--persist':
      case '--scope':
      case '--dry-run':
      case '--':

$ grep -rin "tag" src/cli/config/add.ts src/cli/config/help.ts src/config-schema.ts src/config-normalize.ts src/definition-fields.ts
(no matches)

There is no --tag case; unknown flags hit the default: branch and are silently skipped. The canonical help output (src/cli/config/help.ts) omits --tag, and no tag/tags field exists in config-schema.ts, config-normalize.ts, or definition-fields.ts. The only tag/tags symbols in the tree are unrelated display labels in src/cli/list-format.ts.

  • What was not tested: No behavior change to test — this removes a documentation reference to a flag the CLI never implemented.
  • Proof limitations: Docs-only diff; correctness verified by source inspection of the parser, help, and schema modules named above.

Generated by Claude Code

The 'mcporter config add' flag list in docs/config.md includes '--tag',
but extractAddFlags (src/cli/config/add.ts) has no --tag case: unknown
flags fall through the default branch and are silently skipped. The
canonical help output (src/cli/config/help.ts) omits it, and no tag/tags
field exists in config-schema.ts, config-normalize.ts, or
definition-fields.ts. Following the doc silently drops the value.
@clawsweeper

clawsweeper Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

@clawsweeper clawsweeper Bot added P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels Aug 13, 2026
@clawsweeper

clawsweeper Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Codex review: needs maintainer review before merge. Reviewed August 13, 2026, 4:31 PM ET / 20:31 UTC.

ClawSweeper review

What this changes

The PR removes the nonexistent --tag option from the mcporter config add reference in the configuration guide.

Merge readiness

⚠️ Ready for maintainer review - 2 items remain

Keep this PR open for ordinary documentation review. The one-line diff is internally consistent with the supplied parser/help audit and the prior review found no defect, but this review environment could not run read-only repository commands to independently verify current-main source or history.

Priority: P3
Reviewed head: 2ba2217b4681fa991f2e1b8ae92720bd4b65ae15

Review scores

Measure Result What it means
Overall readiness 🐚 platinum hermit (4/6) The patch is focused and coherent, with a current-main verification gap caused by reviewer-side inspection infrastructure rather than missing contributor proof.
Proof confidence 🌊 off-meta tidepool Not applicable: Real behavior proof is not required because this PR only changes files under docs/.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Verification

Check Result Evidence
Real behavior Not applicable Not applicable: Real behavior proof is not required because this PR only changes files under docs/.
Evidence reviewed 3 items Narrow documentation diff: The supplied PR patch changes one option list in the configuration guide, removing only --tag while leaving the adjacent documented options intact.
Prior review continuity: The previous completed ClawSweeper review of the same head reported no findings and described the change as removing a nonexistent option from the reference.
Inspection infrastructure failure: The required read-only repository inspection could not run: the sandbox rejected git status --short before execution with bwrap: loopback: Failed RTM_NEWADDR: Operation not permitted. Current-main source, history, and release provenance were therefore not independently inspected.
Findings None None.
Security None None.

How this fits together

MCPorter’s configuration CLI turns config add arguments into saved server definitions. The configuration guide is the user-facing reference for the options accepted by that command.

flowchart LR
  A[Configuration guide] --> B[User command]
  B --> C[Configuration CLI]
  C --> D[Argument parsing]
  D --> E[Saved server definition]
Loading

Before merge

  • Resolve merge risk (P1) - Before merge, refresh the review against current main to confirm that the guide, parser, and canonical help still agree; this pass could not perform that check because repository commands failed at the sandbox boundary.
  • Complete next step (P2) - No mechanical repair is indicated; a maintainer or a refreshed review environment should perform the current-main source comparison before merge.
Agent review details

Security

None.

Review metrics

Metric Value Why it matters
Documentation scope 1 file affected; +1, −1 The patch is a narrowly scoped reference correction with no runtime, dependency, or workflow changes.

Merge-risk options

Maintainer options:

  1. Decide the mitigation before merge
    Land the focused documentation correction if a refreshed current-main source check confirms that --tag remains unsupported and undocumented by canonical CLI help.
  2. Pause or close
    Do not merge this PR until maintainers decide whether the risk is worth taking.

Technical review

Best possible solution:

Land the focused documentation correction if a refreshed current-main source check confirms that --tag remains unsupported and undocumented by canonical CLI help.

Do we have a high-confidence way to reproduce the issue?

Not applicable: this is a docs-only correction. The supplied PR body gives a static parser/help comparison, but a current-main source check could not be run in this environment.

Is this the best way to solve the issue?

Unclear: removing the option is the narrowest apparent solution, but the parser and help claims need a refreshed current-main verification before merge.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against 082d790a5817.

Labels

Label justifications:

  • P3: This is a small documentation-correctness improvement with limited user impact and no runtime change.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: Real behavior proof is not required because this PR only changes files under docs/.

Evidence

What I checked:

  • Narrow documentation diff: The supplied PR patch changes one option list in the configuration guide, removing only --tag while leaving the adjacent documented options intact. (docs/config.md:98, 2ba2217b4681)
  • Prior review continuity: The previous completed ClawSweeper review of the same head reported no findings and described the change as removing a nonexistent option from the reference. (docs/config.md:98, 2ba2217b4681)
  • Inspection infrastructure failure: The required read-only repository inspection could not run: the sandbox rejected git status --short before execution with bwrap: loopback: Failed RTM_NEWADDR: Operation not permitted. Current-main source, history, and release provenance were therefore not independently inspected.

Likely related people:

  • Unknown: Local git history and blame could not be read because the sandbox rejected every read-only command, and the PR author is not treated as an owner solely for proposing this patch. (role: current-main area owner unresolved; confidence: low; files: docs/config.md, src/cli/config/add.ts, src/cli/config/help.ts)

Rank-up moves

Optional improvements that raise the rating; they are not merge blockers.

  • Refresh the parser, help, and guide comparison against current main before merging.

Rating scale

Score Internal tier Crab rank Meaning
6/6 S 🦀 challenger crab Exceptional readiness
5/6 A 🦞 diamond lobster Very strong readiness
4/6 B 🐚 platinum hermit Good normal PR; ordinary maintainer review
3/6 C 🦐 gold shrimp Useful, but confidence is limited
2/6 D 🦪 silver shellfish Proof or implementation needs work
1/6 F 🧂 unranked krab Not merge-ready
N/A NA 🌊 off-meta tidepool Rating does not apply

Overall follows the weaker of proof and patch quality.
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

Workflow

  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

History

Review history (1 earlier review cycle)
  • reviewed 2026-08-13T11:31:28.080Z sha 2ba2217 :: needs maintainer review before merge. :: none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant