Improve Validation Logic for Dropout Fraction in DropoutMixin#297
Closed
ram-from-tvl wants to merge 5 commits intoopenclimatefix:mainfrom
Closed
Improve Validation Logic for Dropout Fraction in DropoutMixin#297ram-from-tvl wants to merge 5 commits intoopenclimatefix:mainfrom
DropoutMixin#297ram-from-tvl wants to merge 5 commits intoopenclimatefix:mainfrom
Conversation
Contributor
Author
|
Hi @peterdudfield |
Contributor
|
Please see lint errors I think in general this will be useful |
…pout-fraction' into improve-validation-logic-for-dropout-fraction
Contributor
Author
@peterdudfield |
Member
|
Since this is quite stale now I'm going to close. If you want to do more work to get this in you can always reopen |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This PR improves the validation logic for the
dropout_fractionfield in theDropoutMixinclass. The current implementation allowsdropout_fractionto accept both afloatand alist[float], which introduces ambiguity and complexity in validation.The updated logic ensures:
dropout_fractionis afloat,dropout_timedeltas_minutesmust be empty.dropout_fractionis alist[float], its length must match the length ofdropout_timedeltas_minutes.Let me know if you need further improvements!