Skip to content

refactor: Rename configs to uk_gfs_configs and remove non-GFS yamls#116

Open
zer-art wants to merge 2 commits intoopenclimatefix:mainfrom
zer-art:refactor/114-rename-uk-gfs-configs
Open

refactor: Rename configs to uk_gfs_configs and remove non-GFS yamls#116
zer-art wants to merge 2 commits intoopenclimatefix:mainfrom
zer-art:refactor/114-rename-uk-gfs-configs

Conversation

@zer-art
Copy link

@zer-art zer-art commented Jan 9, 2026

Pull Request

Description

This PR addresses the refactoring of the configuration directory to focus the repository specifically on UK GFS data.

Changes:

  • Directory Rename: Renamed src/open_data_pvnet/configs to src/open_data_pvnet/uk_gfs_configs.

  • Cleanup: Deleted non-GFS configuration files (dwd_data_config.yaml, met_office_global_data_config.yaml, met_office_uk_data_config.yaml) as per instructions to "leave only gfs ones".

  • Path Updates: Updated references to the configuration directory in:

    1. run.py (Main Hydra entry point)

    2. src/open_data_pvnet/scripts/save_samples.py

    3. src/open_data_pvnet/nwp/met_office.py

    4. src/open_data_pvnet/nwp/dwd.py

    5. src/open_data_pvnet/nwp/gfs_dataset.py

  • Documentation: Updated docs/getting_started.md to reflect the new directory structure.

Fixes #114

How Has This Been Tested?

I verified the changes via local execution and static checks.

  • Execution Check (python run.py --help):

Result: The script successfully located and attempted to load the configuration from the new uk_gfs_configs directory.

Note: Execution halted with yaml.constructor.ConstructorError: found duplicate key id. This confirms the path update is correct (Hydra found the file), but validation failed due to a pre-existing syntax issue in wandb.yaml, which was left unmodified to strictly adhere to the scope of this refactor.

  • File Structure Check: Confirmed that src/open_data_pvnet/uk_gfs_configs exists and contains only gfs_data_config.yaml and the PVNet_configs directory.

  • Code Reference Check: Verified that met_office.py and dwd.py paths were updated to the new directory name to maintain code integrity.

  • Yes

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

  • Yes

Checklist:

  • [x ] My code follows OCF's coding style guidelines
  • [ x] I have performed a self-review of my own code
  • [ x] I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • [ x] I have checked my code and corrected any misspellings

Copy link
Contributor

@siddharth7113 siddharth7113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, everything looks good, just a few minor changes.

logger = logging.getLogger(__name__)

CONFIG_PATH = PROJECT_BASE / "src/open_data_pvnet/configs/dwd_data_config.yaml"
CONFIG_PATH = PROJECT_BASE / "src/open_data_pvnet/uk_gfs_configs/dwd_data_config.yaml"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, you could probably leave the configs here as is

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it


# Define the configuration paths for UK and Global
CONFIG_PATHS = {
"uk": PROJECT_BASE / "src/open_data_pvnet/configs/met_office_uk_data_config.yaml",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed this one as well!

@zer-art
Copy link
Author

zer-art commented Jan 16, 2026

Hi @siddharth7113, done! I have reverted the config paths in both met_office.py and dwd.py to point back to the original configs directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename current configs uk_gfs_configs. Leave only gfs ones

2 participants