refactor: Rename configs to uk_gfs_configs and remove non-GFS yamls#116
Open
zer-art wants to merge 2 commits intoopenclimatefix:mainfrom
Open
refactor: Rename configs to uk_gfs_configs and remove non-GFS yamls#116zer-art wants to merge 2 commits intoopenclimatefix:mainfrom
zer-art wants to merge 2 commits intoopenclimatefix:mainfrom
Conversation
siddharth7113
requested changes
Jan 15, 2026
Contributor
siddharth7113
left a comment
There was a problem hiding this comment.
Hi, everything looks good, just a few minor changes.
src/open_data_pvnet/nwp/dwd.py
Outdated
| logger = logging.getLogger(__name__) | ||
|
|
||
| CONFIG_PATH = PROJECT_BASE / "src/open_data_pvnet/configs/dwd_data_config.yaml" | ||
| CONFIG_PATH = PROJECT_BASE / "src/open_data_pvnet/uk_gfs_configs/dwd_data_config.yaml" |
Contributor
There was a problem hiding this comment.
Hi, you could probably leave the configs here as is
|
|
||
| # Define the configuration paths for UK and Global | ||
| CONFIG_PATHS = { | ||
| "uk": PROJECT_BASE / "src/open_data_pvnet/configs/met_office_uk_data_config.yaml", |
Author
|
Hi @siddharth7113, done! I have reverted the config paths in both |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This PR addresses the refactoring of the configuration directory to focus the repository specifically on UK GFS data.
Changes:
Directory Rename: Renamed src/open_data_pvnet/configs to src/open_data_pvnet/uk_gfs_configs.
Cleanup: Deleted non-GFS configuration files (
dwd_data_config.yaml,met_office_global_data_config.yaml,met_office_uk_data_config.yaml) as per instructions to "leave only gfs ones".Path Updates: Updated references to the configuration directory in:
run.py (Main Hydra entry point)
src/open_data_pvnet/scripts/save_samples.py
src/open_data_pvnet/nwp/met_office.py
src/open_data_pvnet/nwp/dwd.py
src/open_data_pvnet/nwp/gfs_dataset.py
Documentation: Updated docs/getting_started.md to reflect the new directory structure.
Fixes #114
How Has This Been Tested?
I verified the changes via local execution and static checks.
File Structure Check: Confirmed that
src/open_data_pvnet/uk_gfs_configsexists and contains onlygfs_data_config.yamland the PVNet_configs directory.Code Reference Check: Verified that met_office.py and dwd.py paths were updated to the new directory name to maintain code integrity.
Yes
If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?
Checklist: