Update GFS data preprocessing for correct longitude range#86
Open
AoufNihed wants to merge 1 commit intoopenclimatefix:mainfrom
Open
Update GFS data preprocessing for correct longitude range#86AoufNihed wants to merge 1 commit intoopenclimatefix:mainfrom
AoufNihed wants to merge 1 commit intoopenclimatefix:mainfrom
Conversation
Contributor
|
@siddharth7113 would you like to review this? |
siddharth7113
requested changes
Apr 6, 2025
Contributor
siddharth7113
left a comment
There was a problem hiding this comment.
Hi @AoufNihed , Thank you for opening a PR on the issue, I see a lot of changes might not be related to the issue #82 , I would request you to not make changes to files unrelated to the issue, this would help in reviewing faster.
Author
|
@siddharth7113 Okay, I will. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #82
Changes Made
constants.pyfor NWP data normalization valuesgfs_dataset.pyto use proper longitude selection for UK regiontest_gfs_dataset.pyto verify longitude handlingTesting
Additional Notes
The current GFS data has longitude values from -10 to 0 for the western UK region, so updated the preprocessing logic to handle this range correctly instead of assuming 350-360 range.