Skip to content

Update GFS data preprocessing for correct longitude range#86

Open
AoufNihed wants to merge 1 commit intoopenclimatefix:mainfrom
AoufNihed:fix-gfs-dataset
Open

Update GFS data preprocessing for correct longitude range#86
AoufNihed wants to merge 1 commit intoopenclimatefix:mainfrom
AoufNihed:fix-gfs-dataset

Conversation

@AoufNihed
Copy link

Fixes #82

Changes Made

  • Modified GFS data preprocessing to handle correct longitude range (-10 to 0 instead of 350 to 360)
  • Added constants.py for NWP data normalization values
  • Updated gfs_dataset.py to use proper longitude selection for UK region
  • Added test cases in test_gfs_dataset.py to verify longitude handling
  • Improved error handling and logging in DWD and GFS data processing

Testing

  • Added unit tests for GFS data preprocessing
  • Verified longitude selection with sample data
  • All tests passing locally:
    • black ✅
    • ruff ✅
    • pre-commit hooks ✅

Additional Notes

The current GFS data has longitude values from -10 to 0 for the western UK region, so updated the preprocessing logic to handle this range correctly instead of assuming 350-360 range.

@peterdudfield
Copy link
Contributor

@siddharth7113 would you like to review this?

Copy link
Contributor

@siddharth7113 siddharth7113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AoufNihed , Thank you for opening a PR on the issue, I see a lot of changes might not be related to the issue #82 , I would request you to not make changes to files unrelated to the issue, this would help in reviewing faster.

@AoufNihed
Copy link
Author

@siddharth7113 Okay, I will.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GFS data doesnt have 350 to 360 latitude

3 participants