Conversation
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## main #86 +/- ##
==========================================
- Coverage 49.87% 49.63% -0.25%
==========================================
Files 23 23
Lines 1644 1652 +8
==========================================
Hits 820 820
- Misses 824 832 +8
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Member
|
@dfulu just looking at open PRs we have, this one still relevant or worth closing? |
Member
Author
I'm actively working on refactoring and cleaning up PVNet right now. So I'd leave this for the moment and come back to it. I think it is a good metric to have, but I also want to cut down on the huge amount of metrics we are using if possible |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Add ramp rate metric.
Note this pull request can't easily be tested until after the Passiv data changes are added, so is left as a draft for now.
Notes:
Fixes #
How Has This Been Tested?
Will be tested locally, after
Checklist: