Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR is focused on repository maintenance, including updating documentation and marking deprecated test files for removal.
- Removed an image table section from the README.
- Added a FIXME comment in a test file regarding its future deletion.
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README.md | Removed outdated image table section from the documentation. |
| OpenCloudTests/Metadata/MetadataDocumentationTests.swift | Added a FIXME comment to indicate the file should be deleted. |
Files not reviewed (2)
- OpenCloud.xcodeproj/xcshareddata/xcschemes/OpenCloud.xcscheme: Language not supported
- tools/GenerateDocs/generate_docs.sh: Language not supported
| import OpenCloudSDK | ||
| import OpenCloudAppShared | ||
|
|
||
| // FIXME: delete all references to this file and then this file. |
There was a problem hiding this comment.
[nitpick] The FIXME comment is ambiguous about whether the file should be removed entirely or updated. Please clarify the intent or remove the file if it is no longer needed.
kulmann
force-pushed
the
repo-maintenance-2
branch
from
4075129 to
0fad33b
Compare
|
Looks OK i guess? |
kulmann
force-pushed
the
repo-maintenance-2
branch
from
0fad33b to
bd97559
Compare
Rebased, but last time CI was failing. Let's see what it says now |
Seems unrelated to this issue. Maybe something needs to be adjusted here: https://github.com/opencloud-eu/ios/blob/main/.github/workflows/build-and-analyze.yml#L25 |
2 participants
Even more repo maintenance..